New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 787603 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Extension content_script CSS is is not re-applied after DOM changes

Reported by tom...@gmail.com, Nov 21 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0

Steps to reproduce the problem:
1. Download and install the attached extension
2. Navigate to http://example.com
3. Wait 10 seconds and observe text color of added DIVs

What is the expected behavior?
All text on the page should have the same (red) text color.

What went wrong?
Text of DIVs added at different times is in different colors, even if only one and the same CSS rule applies to all of them (at one time).

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 64.0.3269.3 (Official Build) dev (64-bit) (cohort: Dev)  Channel: dev
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: 27.0.0.187

This seems to only happen on Windows 7 (Intel i5, integrated graphics).

Couldn't reproduce on Windows 10, Linux or OSX.
 

Comment 1 by tom...@gmail.com, Nov 21 2017

Update to above, this works in Firefox as expected (and in Chrome on other platforms).

Also, missed to attach the extension.
chrome-css-bug.zip
765 bytes Download

Comment 2 by tom...@gmail.com, Nov 21 2017

Also, here is a (50% zoom level) page screenshot of the result I get.
chrome-rainbow.png
8.8 KB View Download

Comment 3 by woxxom@gmail.com, Nov 21 2017

Bisect info: 509091 (good) - 509105 (bad)
https://chromium.googlesource.com/chromium/src/+log/17321e34..2fdeded5?pretty=fuller
Suspecting r509096 = 30168b99604c48a32828f26b5acb2674beea1a5d = https://crrev.com/c/641294 by m.jethani@eyeo.com
"Implement user style sheets"
Landed in 64.0.3242.0

Comment 4 by m.jeth...@eyeo.com, Nov 22 2017

Since this is specific to Windows 7, it would be unlikely that this is because of https://crrev.com/c/641294. Nevertheless I'll take a look.

@woxxom it looks like you accidentally removed a bunch of people from the cc list of https://crrev.com/c/641294
Labels: Needs-Bisect
Cc: sc00335...@techmahindra.com
Components: Platform>Extensions
Labels: -Type-Bug -Pri-2 -Needs-Bisect Triaged-ET M-64 Needs-Triage-M64 hasbisect Pri-1 Type-Bug-Regression
Owner: m.jeth...@eyeo.com
Status: Assigned (was: Unconfirmed)
As per comment#3 suspecting Reviewed-on: https://chromium-review.googlesource.com/641294.

@m.jethani: Please confirm the above issue and feel free to re-assign if it is not related to your change.

Thanks!

Comment 7 by tom...@gmail.com, Nov 22 2017

> Since this is specific to Windows 7, it would be unlikely that this is because

Sorry for the confusion, turns out this probably isn't Windows 7 specific, but Dev 64.0.3269.3 specific (which was only tested on Windows 7).

Just verified everything works as expected in Beta 63.0.3239.59 on Windows 7, and can confirm Dev on other platforms tomorrow.

Comment 8 by woxxom@gmail.com, Nov 22 2017

>@woxxom it looks like you accidentally removed a bunch of people from the cc list of https://crrev.com/c/641294

Sorry about that. Thought I removed them from my message only. If the CL's list got modified I'd say that tracker has a serious priviledge management problem as I'm not affiliated neither to that CL nor to any project at all.

Comment 9 by m.jeth...@eyeo.com, Nov 29 2017

tomica@ can you check with the latest Dev?

We just switched back to author style sheets as the default, this should fix the regression. It would still be an issue with user style sheets, but perhaps we can file that one separately.

Comment 10 by m.jeth...@eyeo.com, Dec 28 2017

Cc: nainar@chromium.org
I have just verified and this is no longer an issue.

nainar@ is it appropriate to mark this is as a duplicate of  issue 632009 ?
Marking as Fixed should do it. Duplicate indicates it is the same issue as reported elsewhere.
Status: Fixed (was: Assigned)

Sign in to add a comment