New issue
Advanced search Search tips

Issue 787589 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug

Blocking:
issue 770833



Sign in to add a comment

Fix temporary reference assignment with --enable-viz.

Project Member Reported by kylec...@chromium.org, Nov 21 2017

Issue description

This code isn't active when --enable-viz is on.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc5c369bf8072b35bad5b148d74f01b5afa4ba29

commit cc5c369bf8072b35bad5b148d74f01b5afa4ba29
Author: kylechar <kylechar@chromium.org>
Date: Tue Nov 28 21:58:31 2017

viz: Assign temporary refernces with --enable-viz.

Fix the logic that decides whether or not to assign temporary references
in HostFrameSinkManager. This fixes temporary references not being
assigned owners when running with --enable-viz in desktop Chrome. Add a
test to verify temporary references are assigned with a remote
FrameSinkmanager.

Also fix some places in HostFrameSinkManager where |frame_sink_manager_|
and |frame_sink_manager_impl_| were mixed up.

Bug:  787589 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I2b40fa332f8afc8ff7fa7b62482ef174bcbd239a
Reviewed-on: https://chromium-review.googlesource.com/793976
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519861}
[modify] https://crrev.com/cc5c369bf8072b35bad5b148d74f01b5afa4ba29/components/viz/host/host_frame_sink_manager.cc
[modify] https://crrev.com/cc5c369bf8072b35bad5b148d74f01b5afa4ba29/components/viz/host/host_frame_sink_manager.h
[modify] https://crrev.com/cc5c369bf8072b35bad5b148d74f01b5afa4ba29/components/viz/host/host_frame_sink_manager_unittest.cc
[modify] https://crrev.com/cc5c369bf8072b35bad5b148d74f01b5afa4ba29/services/ui/ws/window_server.cc

Is this fixed now?
Status: Fixed (was: Started)
Yep.

Sign in to add a comment