Issue 787588 link

Starred by 1 user

Issue metadata

Status:	Started
Owner:	taku...@chromium.org
Cc:	powerb@chromium.org mfo...@chromium.org taku...@chromium.org
Components:	Internals>Cast>UI
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Task

[Media Router UI] Remove the extensionview route controller code

Project Member Reported by taku...@chromium.org, Nov 21 2017

Issue description

We can now remove the following:
- extensionview-related WebUI code
- MediaRouterUIRouteController feature that determined whether the WebUI route controller is enabled (now it will always be enabled)
- MediaRoute's custom_controller_path attribute

We can now remove the following:
- extensionview-related WebUI code
- MediaRouterUIRouteController feature that determined whether the WebUI route controller is enabled (now it will always be enabled)
- MediaRoute's custom_controller_path and supports_media_route_controller attributes

Comment 1 by taku...@chromium.org, Nov 29 2017

Description: Show this description

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bad146345f66f968a42f8bd75d9654914d3b336b

commit bad146345f66f968a42f8bd75d9654914d3b336b
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Fri Dec 01 18:16:53 2017

[Media Router] Remove the extensionview route controller

This removes the extension_view_wrapper view that hosted the extensionview route controller.

This also removes the MediaRouterUIRouteController feature that was used for enabling/disabling the WebUI route controller; it will now always be enabled.
MediaRoute's custom_controller_path attribute will be removed in a separate patch.

Bug: 787588
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I47ac68774dc47d4574125b0ba7730c7567443332
Reviewed-on: https://chromium-review.googlesource.com/775553
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520986}
[modify] https://crrev.com/bad146345f66f968a42f8bd75d9654914d3b336b/chrome/browser/media_router_resources.grdp
[modify] https://crrev.com/bad146345f66f968a42f8bd75d9654914d3b336b/chrome/browser/resources/media_router/elements/route_controls/route_controls.css
[modify] https://crrev.com/bad146345f66f968a42f8bd75d9654914d3b336b/chrome/browser/resources/media_router/elements/route_controls/route_controls.html
[modify] https://crrev.com/bad146345f66f968a42f8bd75d9654914d3b336b/chrome/browser/resources/media_router/elements/route_controls/route_controls.js
[modify] https://crrev.com/bad146345f66f968a42f8bd75d9654914d3b336b/chrome/browser/resources/media_router/elements/route_details/compiled_resources2.gyp
[delete] https://crrev.com/23c523b050b3a7086bcaddb909e9477c8d13ab18/chrome/browser/resources/media_router/elements/route_details/extension_view_wrapper/compiled_resources2.gyp
[delete] https://crrev.com/23c523b050b3a7086bcaddb909e9477c8d13ab18/chrome/browser/resources/media_router/elements/route_details/extension_view_wrapper/extension_view_wrapper.css
[delete] https://crrev.com/23c523b050b3a7086bcaddb909e9477c8d13ab18/chrome/browser/resources/media_router/elements/route_details/extension_view_wrapper/extension_view_wrapper.html
[delete] https://crrev.com/23c523b050b3a7086bcaddb909e9477c8d13ab18/chrome/browser/resources/media_router/elements/route_details/extension_view_wrapper/extension_view_wrapper.js
[modify] https://crrev.com/bad146345f66f968a42f8bd75d9654914d3b336b/chrome/browser/resources/media_router/elements/route_details/route_details.html
[modify] https://crrev.com/bad146345f66f968a42f8bd75d9654914d3b336b/chrome/browser/resources/media_router/elements/route_details/route_details.js
[modify] https://crrev.com/bad146345f66f968a42f8bd75d9654914d3b336b/chrome/browser/resources/media_router/media_router_common.css
[modify] https://crrev.com/bad146345f66f968a42f8bd75d9654914d3b336b/chrome/browser/resources/media_router/media_router_data.js
[modify] https://crrev.com/bad146345f66f968a42f8bd75d9654914d3b336b/chrome/browser/ui/webui/media_router/media_router_resources_provider.cc
[modify] https://crrev.com/bad146345f66f968a42f8bd75d9654914d3b336b/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
[modify] https://crrev.com/bad146345f66f968a42f8bd75d9654914d3b336b/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.h
[modify] https://crrev.com/bad146345f66f968a42f8bd75d9654914d3b336b/chrome/common/chrome_features.cc
[modify] https://crrev.com/bad146345f66f968a42f8bd75d9654914d3b336b/chrome/common/chrome_features.h
[modify] https://crrev.com/bad146345f66f968a42f8bd75d9654914d3b336b/chrome/test/data/webui/media_router/route_details_tests.js

Comment 3 by taku...@chromium.org, Dec 8 2017

More references to extensionview to clean up:
https://cs.chromium.org/chromium/src/chrome/browser/resources/media_router/elements/media_router_container/media_router_container_interface.js?l=100
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/media_router/media_router_ui.cc?l=242
https://cs.chromium.org/chromium/src/chrome/common/media_router/mojo/media_router.mojom?l=114

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4dd7a633499cd7f58e80d27a3ce1f79e0113c121

commit 4dd7a633499cd7f58e80d27a3ce1f79e0113c121
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Fri Dec 08 21:43:21 2017

[Media Router UI] Remove obsolete attributes from MediaRoute

This CL removes custom_controller_path and supports_media_route_controller, which are no longer used.

Bug: 787588
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic2f1efd5000cdc39ef22092c313a27e9fb02b19b
Reviewed-on: https://chromium-review.googlesource.com/777478
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522884}
[modify] https://crrev.com/4dd7a633499cd7f58e80d27a3ce1f79e0113c121/chrome/browser/media/android/router/media_router_android.cc
[modify] https://crrev.com/4dd7a633499cd7f58e80d27a3ce1f79e0113c121/chrome/browser/media/router/local_presentation_manager_unittest.cc
[modify] https://crrev.com/4dd7a633499cd7f58e80d27a3ce1f79e0113c121/chrome/browser/media/router/media_router_base_unittest.cc
[modify] https://crrev.com/4dd7a633499cd7f58e80d27a3ce1f79e0113c121/chrome/browser/media/router/media_router_dialog_controller_unittest.cc
[modify] https://crrev.com/4dd7a633499cd7f58e80d27a3ce1f79e0113c121/chrome/browser/media/router/mojo/extension_media_route_provider_proxy_unittest.cc
[modify] https://crrev.com/4dd7a633499cd7f58e80d27a3ce1f79e0113c121/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/4dd7a633499cd7f58e80d27a3ce1f79e0113c121/chrome/browser/media/router/mojo/media_router_mojo_test.cc
[modify] https://crrev.com/4dd7a633499cd7f58e80d27a3ce1f79e0113c121/chrome/browser/media/router/mojo/wired_display_media_route_provider.cc
[modify] https://crrev.com/4dd7a633499cd7f58e80d27a3ce1f79e0113c121/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/4dd7a633499cd7f58e80d27a3ce1f79e0113c121/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc
[modify] https://crrev.com/4dd7a633499cd7f58e80d27a3ce1f79e0113c121/chrome/browser/ui/toolbar/media_router_action_controller_unittest.cc
[modify] https://crrev.com/4dd7a633499cd7f58e80d27a3ce1f79e0113c121/chrome/browser/ui/toolbar/media_router_action_unittest.cc
[modify] https://crrev.com/4dd7a633499cd7f58e80d27a3ce1f79e0113c121/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc
[modify] https://crrev.com/4dd7a633499cd7f58e80d27a3ce1f79e0113c121/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
[modify] https://crrev.com/4dd7a633499cd7f58e80d27a3ce1f79e0113c121/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
[modify] https://crrev.com/4dd7a633499cd7f58e80d27a3ce1f79e0113c121/chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc
[modify] https://crrev.com/4dd7a633499cd7f58e80d27a3ce1f79e0113c121/chrome/common/media_router/media_route.cc
[modify] https://crrev.com/4dd7a633499cd7f58e80d27a3ce1f79e0113c121/chrome/common/media_router/media_route.h
[modify] https://crrev.com/4dd7a633499cd7f58e80d27a3ce1f79e0113c121/chrome/common/media_router/media_route_unittest.cc
[modify] https://crrev.com/4dd7a633499cd7f58e80d27a3ce1f79e0113c121/chrome/common/media_router/mojo/media_router.mojom
[modify] https://crrev.com/4dd7a633499cd7f58e80d27a3ce1f79e0113c121/chrome/common/media_router/mojo/media_router_struct_traits.cc
[modify] https://crrev.com/4dd7a633499cd7f58e80d27a3ce1f79e0113c121/chrome/common/media_router/mojo/media_router_struct_traits.h
[modify] https://crrev.com/4dd7a633499cd7f58e80d27a3ce1f79e0113c121/chrome/renderer/resources/extensions/media_router_bindings.js

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07f1af56dad01198fda37a44e5671aa8bc93a018

commit 07f1af56dad01198fda37a44e5671aa8bc93a018
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Wed Jan 17 02:57:46 2018

[Media Router] Cleanup: Remove MRUI code to obtain extension ID

Media Router UI used component extension ID for generating extensionview controller URL. Now the extensionview is gone, this can be removed.

Bug: 787588
Change-Id: I6929931ccdc57ea8477611e72f1ddec467584f59
Reviewed-on: https://chromium-review.googlesource.com/842471
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529557}
[modify] https://crrev.com/07f1af56dad01198fda37a44e5671aa8bc93a018/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/07f1af56dad01198fda37a44e5671aa8bc93a018/chrome/browser/ui/webui/media_router/media_router_ui.h
[modify] https://crrev.com/07f1af56dad01198fda37a44e5671aa8bc93a018/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
[modify] https://crrev.com/07f1af56dad01198fda37a44e5671aa8bc93a018/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
[modify] https://crrev.com/07f1af56dad01198fda37a44e5671aa8bc93a018/chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc

Comment 6 by mfo...@chromium.org, Aug 2

Cc: powerb@chromium.org

►

Issue 787588 link

Issue metadata

[Media Router UI] Remove the extensionview route controller code

Issue description

Comment 1 by taku...@chromium.org, Nov 29 2017

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Dec 1 2017

Comment 2 Deleted

Comment 3 by taku...@chromium.org, Dec 8 2017

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Dec 8 2017

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Jan 17 2018

Comment 5 Deleted

Comment 6 by mfo...@chromium.org, Aug 2

Comment 6 Deleted

Sign in to add a comment