VR: AudioPermissionPrompt should support RTL |
||||||
Issue descriptionAudioPermissionPrompt should supprt RTL. Currently the main text is not in the correct position
,
Nov 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be87c109ba28314db9ab79cf89572e292ff3576b commit be87c109ba28314db9ab79cf89572e292ff3576b Author: Amirhossein Simjour <asimjour@chromium.org> Date: Thu Nov 30 16:22:31 2017 [VR] Fix text length and positioning in audio permission prompt In case that translated string is too long, this fix will make sure that the text and icon won't overlap. Moreover, text won't be too close to the edge. Bug: 783341, 787587 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie1f7c6bbf936923e20eb9184d02ab6158b8294fa Reviewed-on: https://chromium-review.googlesource.com/788335 Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Reviewed-by: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#520565} [modify] https://crrev.com/be87c109ba28314db9ab79cf89572e292ff3576b/chrome/browser/vr/elements/audio_permission_prompt_texture.cc
,
Dec 7 2017
,
Dec 11 2017
Is this ticket about main text alignment only? It looks like Microphone icon and action buttons should also be realigned. I'm attaching 2 screenshots, "2D_prompt_RTL.png" shows RTL layout for standard permission prompt in 2D.
,
Dec 11 2017
,
Jan 8 2018
I believe this bug was about the text not displaying correctly at all. Please file a separate bug for the UI arrangement. Also, do other VR UI elements have the same issue? Thanks.
,
Jan 8 2018
I mark this as fixed and start a new one for the alignment. The alignment does not have the same priority.
,
Feb 7 2018
,
Feb 7 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ddorwin@chromium.org
, Nov 21 2017