New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 787587 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR

Blocking:
issue 773754



Sign in to add a comment

VR: AudioPermissionPrompt should support RTL

Project Member Reported by asimjour@chromium.org, Nov 21 2017

Issue description

AudioPermissionPrompt should supprt RTL. Currently the main text is not in the correct position
 
Blocking: 773754
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be87c109ba28314db9ab79cf89572e292ff3576b

commit be87c109ba28314db9ab79cf89572e292ff3576b
Author: Amirhossein Simjour <asimjour@chromium.org>
Date: Thu Nov 30 16:22:31 2017

[VR] Fix text length and positioning in audio permission prompt

In case that translated string is too long, this fix will make sure that the
text and icon won't overlap. Moreover, text won't be too close to the edge.

Bug: 783341,  787587 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ie1f7c6bbf936923e20eb9184d02ab6158b8294fa
Reviewed-on: https://chromium-review.googlesource.com/788335
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520565}
[modify] https://crrev.com/be87c109ba28314db9ab79cf89572e292ff3576b/chrome/browser/vr/elements/audio_permission_prompt_texture.cc

Status: Fixed (was: Assigned)
Is this ticket about main text alignment only? It looks like Microphone icon and action buttons should also be realigned. I'm attaching 2 screenshots, "2D_prompt_RTL.png" shows RTL layout for standard permission prompt in 2D.
2D_prompt_RTL.png
43.0 KB View Download
ChromeVR_prompt_RTL.png
40.6 KB View Download
Status: Assigned (was: Fixed)
I believe this bug was about the text not displaying correctly at all.

Please file a separate bug for the UI arrangement. Also, do other VR UI elements have the same issue? Thanks.
Status: Fixed (was: Assigned)
I mark this as fixed and start a new one for the alignment. The alignment does not have the same priority.
Labels: Test-Manual
Labels: Test-Manual

Sign in to add a comment