New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 787580 link

Starred by 1 user
Status: Fixed
Owner:
█ allada@chromium.org
Last visit > 30 days ago
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Waterfall column sometimes has a zero size header

Project Member Reported by allada@chromium.org, Nov 21 2017 
In devtools if you open network panel and click a request then toggle the large rows setting then deselect a request the waterfall header size is 0.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34fd79519a6d92f30977b90fae8ec9d2a736582c

commit 34fd79519a6d92f30977b90fae8ec9d2a736582c
Author: Blaise <allada@chromium.org>
Date: Wed Nov 22 00:59:27 2017

[Devtools] Fixed waterfall header sometimes not getting right height

Fixed bug where the height of the columns headers may not be rendered
and the waterfall column gets a header height of 0, resulting in the
waterfall displaying improperly

R=pfeldman,dgozman
BUG= 787580 

Change-Id: Ice80526d33429ee17b728b674344d7817bd12f2b
Reviewed-on: https://chromium-review.googlesource.com/783650
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Blaise Bruer <allada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518478}
[add] https://crrev.com/34fd79519a6d92f30977b90fae8ec9d2a736582c/third_party/WebKit/LayoutTests/http/tests/devtools/network/waterfall-header-height-updates-expected.txt
[add] https://crrev.com/34fd79519a6d92f30977b90fae8ec9d2a736582c/third_party/WebKit/LayoutTests/http/tests/devtools/network/waterfall-header-height-updates.js
[modify] https://crrev.com/34fd79519a6d92f30977b90fae8ec9d2a736582c/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
[modify] https://crrev.com/34fd79519a6d92f30977b90fae8ec9d2a736582c/third_party/WebKit/Source/devtools/front_end/network_test_runner/NetworkTestRunner.js

Comment 2 by allada@chromium.org, Dec 1 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment