New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 787556 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 787555



Sign in to add a comment

Eliminate cros_best_revision from chromite

Project Member Reported by steve...@chromium.org, Nov 21 2017

Issue description

Once we turn down the Chrome LKGM builder we should remove cros_best_revision from chromite since it was used exclusively by that builder.

 
Owner: steve...@chromium.org
Labels: M-65
Cc: ihf@chromium.org derat@chromium.org michae...@chromium.org steve...@chromium.org achuith@chromium.org josa...@chromium.org jamescook@chromium.org
 Issue 726130  has been merged into this issue.
Labels: -M-65
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/39517eeb1740b74a77f8ced3eb31212f7cf4d030

commit 39517eeb1740b74a77f8ced3eb31212f7cf4d030
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Feb 07 19:17:29 2018

Elim cros_best_revision

All usage of this script was eliminated in the work for
 crbug.com/732579 , this is just the code cleanup to remove it.

BUG= chromium:787556 
TEST=none
Change-Id: I1ecf5d16288b40691c8cd5d32edb21ceed48583d
Reviewed-on: https://chromium-review.googlesource.com/903367
Tested-by: Steven Bennetts <stevenjb@chromium.org>
Trybot-Ready: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[delete] https://crrev.com/35d2ed0affbdcbd2879296b993b322b437bf09e0/scripts/cros_best_revision.py
[delete] https://crrev.com/35d2ed0affbdcbd2879296b993b322b437bf09e0/bin/cros_best_revision
[delete] https://crrev.com/35d2ed0affbdcbd2879296b993b322b437bf09e0/scripts/cros_best_revision_unittest.py
[delete] https://crrev.com/35d2ed0affbdcbd2879296b993b322b437bf09e0/scripts/cros_best_revision_unittest

Status: Fixed (was: Started)

Sign in to add a comment