Issue metadata
Sign in to add a comment
|
plugins/webview-plugin-type-change.html in webkit_layout_tests failing on multiple builders |
||||||||||||||||||||||||
Issue descriptionplugins/webview-plugin-type-change.html in webkit_layout_tests failing on multiple builders Builders failed on: - Mac10.10 Tests: https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests - Mac10.11 Tests: https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests - Mac10.12 Tests: https://build.chromium.org/p/chromium.mac/builders/Mac10.12%20Tests - WebKit Mac10.10: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10 - WebKit Mac10.11 (dbg): https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29 - WebKit Mac10.11: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11 - WebKit Mac10.12: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.12
,
Nov 21 2017
Yeah, I'm dumb: this is a Mac specific error and I'm trying to bisect it in Linux. Searching for someone who can test it...
,
Nov 21 2017
,
Nov 21 2017
wez@ is attempting to bisect this (through SSH). Let's see how it goes...
,
Nov 21 2017
Running layout tests via SSH didn't work. I borrowed a MacBook and did the bisect. It seems the culprit is commit 6809a4d6fe9136335e05f06ddf04e10ab15b6d63 reviewed at https://chromium-review.googlesource.com/779883. Will revert.
,
Nov 21 2017
,
Nov 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/915ae8f5328453f7c0190b784683fb0005568567 commit 915ae8f5328453f7c0190b784683fb0005568567 Author: Carlos Knippschild <carlosk@chromium.org> Date: Tue Nov 21 23:36:42 2017 Revert "Use scanout overlays for pepper2d when possible." This reverts commit 6809a4d6fe9136335e05f06ddf04e10ab15b6d63. Reason for revert: This is breaking many Mac builds (see linked issue). Original change's description: > Use scanout overlays for pepper2d when possible. > > If GL image textures are supported, and we can find the image texture > target for the desired format, then use TexStorage2DImageCHROMIUM to > allocate the texture so that it may be used for scanout. > > R=piman@chromium.org > > Bug: 786140 > Change-Id: I36875f82796614f4d5c7290f27bd0bacfce510fb > Reviewed-on: https://chromium-review.googlesource.com/779883 > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#518269} TBR=danakj@chromium.org,piman@chromium.org Change-Id: I747d76984c0641a01a44e62595432d287baf7405 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 786140 , 787548 Reviewed-on: https://chromium-review.googlesource.com/783491 Reviewed-by: Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#518449} [modify] https://crrev.com/915ae8f5328453f7c0190b784683fb0005568567/content/renderer/pepper/pepper_graphics_2d_host.cc [modify] https://crrev.com/915ae8f5328453f7c0190b784683fb0005568567/content/renderer/pepper/pepper_graphics_2d_host.h
,
Nov 21 2017
,
Nov 21 2017
This is tracking the failing bots not the causing issue. I'll keep this opened until the bots are back green. Please track the actual fix elsewhere.
,
Nov 21 2017
Ok sorry.
,
Nov 22 2017
Mac builds are back to green. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by carl...@google.com
, Nov 21 2017