New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 787544 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 773754



Sign in to add a comment

Use roboto medium for text in the buttons in audio permission prompt

Project Member Reported by bshe@chromium.org, Nov 21 2017

Issue description

Currently, we use roboto. The UX spec is to use roboto medium.

assign to Amir per offline discussion. Thanks!
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d6b912c542e6c7aaad2210e8b21e9fa7c3301d5

commit 9d6b912c542e6c7aaad2210e8b21e9fa7c3301d5
Author: Biao She <bshe@chromium.org>
Date: Wed Nov 29 18:10:20 2017

Use roboto.medium for text in Audio permission button


Bug:  787544 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Idee5839a230fbef3df7b681c5c822cca1e4d62c0
Reviewed-on: https://chromium-review.googlesource.com/794770
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Biao She <bshe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520164}
[modify] https://crrev.com/9d6b912c542e6c7aaad2210e8b21e9fa7c3301d5/chrome/browser/vr/elements/audio_permission_prompt_texture.cc
[modify] https://crrev.com/9d6b912c542e6c7aaad2210e8b21e9fa7c3301d5/chrome/browser/vr/elements/exclusive_screen_toast_texture.cc
[modify] https://crrev.com/9d6b912c542e6c7aaad2210e8b21e9fa7c3301d5/chrome/browser/vr/elements/exit_prompt_texture.cc
[modify] https://crrev.com/9d6b912c542e6c7aaad2210e8b21e9fa7c3301d5/chrome/browser/vr/elements/exit_warning_texture.cc
[modify] https://crrev.com/9d6b912c542e6c7aaad2210e8b21e9fa7c3301d5/chrome/browser/vr/elements/system_indicator_texture.cc
[modify] https://crrev.com/9d6b912c542e6c7aaad2210e8b21e9fa7c3301d5/chrome/browser/vr/elements/text.cc
[modify] https://crrev.com/9d6b912c542e6c7aaad2210e8b21e9fa7c3301d5/chrome/browser/vr/elements/text_input.cc
[modify] https://crrev.com/9d6b912c542e6c7aaad2210e8b21e9fa7c3301d5/chrome/browser/vr/elements/ui_texture.cc
[modify] https://crrev.com/9d6b912c542e6c7aaad2210e8b21e9fa7c3301d5/chrome/browser/vr/elements/ui_texture.h
[modify] https://crrev.com/9d6b912c542e6c7aaad2210e8b21e9fa7c3301d5/chrome/browser/vr/elements/url_bar_texture.cc
[modify] https://crrev.com/9d6b912c542e6c7aaad2210e8b21e9fa7c3301d5/chrome/browser/vr/elements/url_bar_texture_unittest.cc
[modify] https://crrev.com/9d6b912c542e6c7aaad2210e8b21e9fa7c3301d5/chrome/browser/vr/elements/webvr_url_toast_texture.cc

Comment 2 by bshe@chromium.org, Nov 29 2017

Owner: bshe@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment