New issue
Advanced search Search tips

Issue 787535 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Task
Team-Security-UX

Blocking:
issue 756654



Sign in to add a comment

Only send SSLInfo from network service on top-level requests

Project Member Reported by est...@chromium.org, Nov 21 2017

Issue description

We currently request SSLInfo from the network service on all navigation requests, but we in fact only need it on top-level main-frame requests. (That is the only certificate the user can inspect without refreshing the page with DevTools open.)

Since certificate chains can be large, we should omit the SSLInfo on subframe requests.
 

Comment 1 by est...@chromium.org, Nov 21 2017

Labels: Hotlist-GoodFirstBug

Comment 2 by jam@chromium.org, Nov 21 2017

Blocking: 756654
Components: Internals>Services>Network

Comment 3 by dxie@chromium.org, May 17 2018

hi estark@, has this been fixed?

Comment 4 by est...@chromium.org, May 17 2018

No. This is an optimization, though, so I wouldn't consider it blocking for anything.

Comment 5 by dxie@chromium.org, May 30 2018

Labels: Hotlist-KnownIssue
Owner: livvielin@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/139bf442fac22bf19e96704b228f122cd20a7b2b

commit 139bf442fac22bf19e96704b228f122cd20a7b2b
Author: Livvie Lin <livvielin@chromium.org>
Date: Fri Aug 10 00:18:54 2018

Stop sending SSLInfo from network service for subframe navigations.

Optimize to only send SSLInfo from network service on top-level requests.
Changes GetURLLoaderOptions to only set
kURLLoadOptionSendSSLInfoWithResponse when |is_main_frame| is true and
sets new default to kURLLoadOptionNone.

This also makes a change in WebContentsImpl to fetch SSLInfo only on
main frame navigations.

Bug:  787535 
Change-Id: Ie4a929ba90e4c358d111e174a3c399298f22b5f3
Reviewed-on: https://chromium-review.googlesource.com/1148239
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581974}
[modify] https://crrev.com/139bf442fac22bf19e96704b228f122cd20a7b2b/content/browser/loader/navigation_url_loader_impl.cc
[modify] https://crrev.com/139bf442fac22bf19e96704b228f122cd20a7b2b/content/browser/web_contents/web_contents_impl.cc

Status: Fixed (was: Assigned)

Sign in to add a comment