New issue
Advanced search Search tips

Issue 787524 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Wrong raster scale during transition with viewport aspect ratio.

Project Member Reported by chrishtr@chromium.org, Nov 21 2017

Issue description

Testcase attached.
 
test2.html
1.1 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed7d4d2822d2974339093df4656c87dc2789d5bf

commit ed7d4d2822d2974339093df4656c87dc2789d5bf
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Wed Nov 22 18:48:09 2017

Use the square of the maximum viewport dimension for "max raster scale" during animations.

Currently, we use the actual viewport size (width * height), but compare it with the
maximum of the transform scale factor in any direction. This prevents animations up to
near the actual viewport size when the viewport aspect ratio is far from 1, because the
heuristically-computed "scale" of the image looks larger than the viewport.

Bug:  787524 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Idda22addcc989b97d4eeaa06807b7b5874433d5a
Reviewed-on: https://chromium-review.googlesource.com/782761
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518694}
[modify] https://crrev.com/ed7d4d2822d2974339093df4656c87dc2789d5bf/cc/layers/picture_layer_impl.cc
[modify] https://crrev.com/ed7d4d2822d2974339093df4656c87dc2789d5bf/cc/layers/picture_layer_impl_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment