New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 787518 link

Starred by 1 user
Status: Untriaged
Owner: ----
Cc:
█ brettw@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocking:
issue crashpad:79



Sign in to add a comment

gn: tool without `command` causes silent crash

Project Member Reported by scottmg@chromium.org, Nov 21 2017 
I added a placeholder tool to a new BUILDCONFIG.gn

  tool("solink_module") {
    # TODO: Implement.
    outputs = [
      "{{target_output_name}}{{output_extension}}",
    ]
  }

When generating, I was surprised there was no build.ninja. After some confusion, it seems that if there's no command entry, gn crashes (or exits).

I guess it's likely hitting https://cs.chromium.org/chromium/src/tools/gn/ninja_toolchain_writer.cc?rcl=64337af3fa6a5ed60960b65a70ca8ba060483cc4&l=92 (I didn't check) but it'd be nice if there was an error earlier somewhere.

Comment 1 by dpranke@chromium.org, Nov 21 2017

Components: Build
BUILDCONFIG, or a BUILD.gn file? I don't think you can define tools in BUILDCONFIG, but I could be wrong.

Regardless, we shouldn't crash, though.

Comment 2 by scottmg@chromium.org, Nov 21 2017 

Er, sorry, yeah. build/BUILD.gn, not BUILDCONFIG.gn.

Comment 3 by krajshree@chromium.org, Nov 23 2017

Labels: Needs-Milestone Triaged-ET TE-NeedsTriageHelp
The issue seems to be out of TE-scope as it is related to build. Hence, adding label TE-NeedsTriageHelp for further investigation from dev team.

Thanks...!!

Comment 4 by dpranke@chromium.org, Nov 28 2017

Labels: -TE-NeedsTriageHelp -Needs-Milestone -Triaged-ET
Status: Untriaged (was: Unconfirmed)
clearing triage labels, this is just a dev issue. 

@scottmg: I'm guessing this isn't really blocking the crashpad conversion?

Comment 5 by scottmg@chromium.org, Nov 28 2017 

No, not blocking, that was just a "relatedly".
►

Sign in to add a comment