MediaCanPlayTypeTest.CodecSupportTest_av1 fails |
||||||
Issue description
What steps will reproduce the problem?
(1) "checkout_libaom": True
(2) ./out/Default/content_browsertests --gtest_filter=\*av1\*
What happens instead?
[ RUN ] MediaCanPlayTypeTest.CodecSupportTest_av1
[25286:25306:1121/095512.576006:ERROR:instance.cc(49)] Unable to locate service manifest for metrics
[25286:25306:1121/095512.576107:ERROR:service_manager.cc(889)] Failed to resolve service name: metrics
DevTools listening on ws://127.0.0.1:36311/devtools/browser/cf8e89ae-3318-455e-9ee5-6ec8a2913823
[25286:25306:1121/095513.077028:ERROR:instance.cc(49)] Unable to locate service manifest for metrics
[25286:25306:1121/095513.077092:ERROR:service_manager.cc(889)] Failed to resolve service name: metrics
../../content/browser/media/media_canplaytype_browsertest.cc:606: Failure
Expected: kProbably
Which is: "probably"
To be equal to: CanPlay("'video/mp4; codecs=\"av1\"'")
Which is: ""
[25312:25312:1121/095513.148713:WARNING:ipc_message_attachment_set.cc(49)] MessageAttachmentSet destroyed with unconsumed attachments: 0/1
[25312:25312:1121/095513.148812:WARNING:ipc_message_attachment_set.cc(49)] MessageAttachmentSet destroyed with unconsumed attachments: 0/1
[ FAILED ] MediaCanPlayTypeTest.CodecSupportTest_av1, where TypeParam = and GetParam() = (635 ms)
https://logs.chromium.org/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux%2Flinux_chromium_asan_rel_ng%2F494983%2F%2B%2Frecipes%2Fsteps%2Fcontent_browsertests__with_patch_%2F0%2Flogs%2FMediaCanPlayTypeTest.CodecSupportTest_av1%2F0
,
Nov 21 2017
dalecurtis@xorax /d/code/chrome/src $ ./out/Release/content_browsertests --gtest_filter=*av1* IMPORTANT DEBUGGING NOTE: each test is run inside its own process. For debugging a test inside a debugger, use the --gtest_filter=<your_test_name> flag along with either --single_process (to run the test in one launcher/browser process) or --single-process (to do the above, and also run Chrome in single-process mode). Using sharding settings from environment. This is shard 0/1 Using 1 parallel jobs. Note: Google Test filter = MediaCanPlayTypeTest.CodecSupportTest_av1 [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from MediaCanPlayTypeTest, where TypeParam = [ RUN ] MediaCanPlayTypeTest.CodecSupportTest_av1 [140018:140042:1121/115622.638691:ERROR:instance.cc(49)] Unable to locate service manifest for metrics [140018:140042:1121/115622.638766:ERROR:service_manager.cc(889)] Failed to resolve service name: metrics DevTools listening on ws://127.0.0.1:42157/devtools/browser/521a0d08-f2cf-4e74-93bd-a5cf26959a6f [140046:140046:1121/115623.025326:ERROR:gpu_info.cc(103)] No active GPU found, returning primary GPU. [140018:140042:1121/115623.684158:ERROR:instance.cc(49)] Unable to locate service manifest for metrics [140018:140042:1121/115623.684215:ERROR:service_manager.cc(889)] Failed to resolve service name: metrics [ OK ] MediaCanPlayTypeTest.CodecSupportTest_av1 (1571 ms) [----------] 1 test from MediaCanPlayTypeTest (1571 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (1571 ms total) [ PASSED ] 1 test. I can't repro this one. What are your build args?
,
Nov 21 2017
is_debug = false use_goma = true goma_dir = "/usr/local/google/home/johannkoenig/chromium/goma/" I get your output with enable_av1_decoder = false
,
Nov 21 2017
I picked this up from the bot: https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_tsan_rel_ng/200329 https://luci-milo.appspot.com/buildbot/tryserver.chromium.linux/linux_chromium_asan_rel_ng/494983 asan and tsan ... but I'm not building a sanitized target locally for the repro.
,
Nov 21 2017
Ah I think you don't have proprietary codecs enabled so my test was only passing because of video/mp4 and video/webm are kProbably. It wasn't taking the codec into account. Fix incoming.
,
Nov 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b536391fe46113bac96028988b6fdd6447b4d215 commit b536391fe46113bac96028988b6fdd6447b4d215 Author: Dale Curtis <dalecurtis@chromium.org> Date: Mon Nov 27 21:11:27 2017 Fix CodecSupportTest_av1 when proprietary_codecs=false This test was not actually testing the right thing, by default video/mp4 and video/webm with an unknown codec are reported as "probably" being supported. Fix this so that av1 is recognized and return "" if support is not compiled or enabled. BUG= 787514 TEST=updated browsertest Change-Id: I14a62d5789b1def48413989eb859dcd1a878294b Reviewed-on: https://chromium-review.googlesource.com/783330 Reviewed-by: Johann Koenig <johannkoenig@google.com> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#519402} [modify] https://crrev.com/b536391fe46113bac96028988b6fdd6447b4d215/content/browser/media/media_canplaytype_browsertest.cc [modify] https://crrev.com/b536391fe46113bac96028988b6fdd6447b4d215/media/base/mime_util_internal.cc
,
Nov 27 2017
,
Nov 27 2017
Might still be a problem on mac: https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/598343 https://logs.chromium.org/v/?s=chromium%2Fbb%2Ftryserver.chromium.mac%2Fmac_chromium_rel_ng%2F598343%2F%2B%2Frecipes%2Fsteps%2Fcontent_browsertests__with_patch_%2F0%2Flogs%2FAV1MediaCanPlayTypeTest.CodecSupportTest_av1%2F0 [ RUN ] AV1MediaCanPlayTypeTest.CodecSupportTest_av1 DevTools listening on ws://127.0.0.1:53223/devtools/browser/e318091e-b382-4e1a-91c3-9f059c3ee422 [3436:38147:1127/134808.489711:ERROR:instance.cc(49)] Unable to locate service manifest for metrics [3436:38147:1127/134808.489822:ERROR:service_manager.cc(889)] Failed to resolve service name: metrics [3437:771:1127/134808.549322:WARNING:vt_video_decode_accelerator_mac.cc(178)] Failed to create VTDecompressionSession: Error Domain=NSOSStatusErrorDomain Code=-8973 "The operation couldn?t be completed. (OSStatus error -8973.)" (codecOpenErr) (-8973) [3437:771:1127/134808.551150:WARNING:vt_video_decode_accelerator_mac.cc(200)] Failed to create hardware VideoToolbox session [3437:771:1127/134808.646947:ERROR:vt_video_encode_accelerator_mac.cc(517)] VTCompressionSessionCreate failed: -12908 [3436:38147:1127/134808.646994:ERROR:service_manager.cc(889)] Failed to resolve service name: metrics ../../content/browser/media/media_canplaytype_browsertest.cc:605: Failure Expected: kNot Which is: "" To be equal to: CanPlay("'video/mp4; codecs=\"av1\"'") Which is: "probably" [ FAILED ] AV1MediaCanPlayTypeTest.CodecSupportTest_av1, where TypeParam = and GetParam() = (590 ms) [ RUN ] AV1MediaCanPlayTypeTest.CodecSupportTest_av1 DevTools listening on ws://127.0.0.1:57646/devtools/browser/c7573fba-a379-40fe-9724-6c35e5a41b47 [6999:37891:1127/135342.912607:ERROR:instance.cc(49)] Unable to locate service manifest for metrics [6999:37891:1127/135342.912711:ERROR:service_manager.cc(889)] Failed to resolve service name: metrics [7000:771:1127/135342.987855:WARNING:vt_video_decode_accelerator_mac.cc(178)] Failed to create VTDecompressionSession: Error Domain=NSOSStatusErrorDomain Code=-8973 "The operation couldn?t be completed. (OSStatus error -8973.)" (codecOpenErr) (-8973) [7000:771:1127/135342.989493:WARNING:vt_video_decode_accelerator_mac.cc(200)] Failed to create hardware VideoToolbox session [6999:37891:1127/135343.058186:ERROR:instance.cc(49)] Unable to locate service manifest for metrics [6999:37891:1127/135343.058230:ERROR:service_manager.cc(889)] Failed to resolve service name: metrics [7000:771:1127/135343.058957:ERROR:vt_video_encode_accelerator_mac.cc(517)] VTCompressionSessionCreate failed: -12908 ../../content/browser/media/media_canplaytype_browsertest.cc:605: Failure Expected: kNot Which is: "" To be equal to: CanPlay("'video/mp4; codecs=\"av1\"'") Which is: "probably" [ FAILED ] AV1MediaCanPlayTypeTest.CodecSupportTest_av1, where TypeParam = and GetParam() = (459 ms) [ RUN ] AV1MediaCanPlayTypeTest.CodecSupportTest_av1 DevTools listening on ws://127.0.0.1:57647/devtools/browser/feb45623-49cd-440e-921f-4881d96e9bdb [7002:37891:1127/135343.451653:ERROR:instance.cc(49)] Unable to locate service manifest for metrics [7002:37891:1127/135343.451731:ERROR:service_manager.cc(889)] Failed to resolve service name: metrics [7003:771:1127/135343.520567:WARNING:vt_video_decode_accelerator_mac.cc(178)] Failed to create VTDecompressionSession: Error Domain=NSOSStatusErrorDomain Code=-8973 "The operation couldn?t be completed. (OSStatus error -8973.)" (codecOpenErr) (-8973) [7003:771:1127/135343.521734:WARNING:vt_video_decode_accelerator_mac.cc(200)] Failed to create hardware VideoToolbox session [7003:771:1127/135343.583984:ERROR:vt_video_encode_accelerator_mac.cc(517)] VTCompressionSessionCreate failed: -12908 [7002:37891:1127/135343.584031:ERROR:instance.cc(49)] Unable to locate service manifest for metrics [7002:37891:1127/135343.584077:ERROR:service_manager.cc(889)] Failed to resolve service name: metrics ../../content/browser/media/media_canplaytype_browsertest.cc:605: Failure Expected: kNot Which is: "" To be equal to: CanPlay("'video/mp4; codecs=\"av1\"'") Which is: "probably" [ FAILED ] AV1MediaCanPlayTypeTest.CodecSupportTest_av1, where TypeParam = and GetParam() = (418 ms) [ RUN ] AV1MediaCanPlayTypeTest.CodecSupportTest_av1 DevTools listening on ws://127.0.0.1:57648/devtools/browser/8adcf149-5fa8-4956-a924-2d1dd6a98ae1 [7005:37891:1127/135343.948217:ERROR:instance.cc(49)] Unable to locate service manifest for metrics [7005:37891:1127/135343.948322:ERROR:service_manager.cc(889)] Failed to resolve service name: metrics [7006:771:1127/135344.011340:WARNING:vt_video_decode_accelerator_mac.cc(178)] Failed to create VTDecompressionSession: Error Domain=NSOSStatusErrorDomain Code=-8973 "The operation couldn?t be completed. (OSStatus error -8973.)" (codecOpenErr) (-8973) [7006:771:1127/135344.013180:WARNING:vt_video_decode_accelerator_mac.cc(200)] Failed to create hardware VideoToolbox session [7005:37891:1127/135344.085118:ERROR:instance.cc(49)] Unable to locate service manifest for metrics [7005:37891:1127/135344.085179:ERROR:service_manager.cc(889)] Failed to resolve service name: metrics [7006:771:1127/135344.085446:ERROR:vt_video_encode_accelerator_mac.cc(517)] VTCompressionSessionCreate failed: -12908 ../../content/browser/media/media_canplaytype_browsertest.cc:605: Failure Expected: kNot Which is: "" To be equal to: CanPlay("'video/mp4; codecs=\"av1\"'") Which is: "probably" [ FAILED ] AV1MediaCanPlayTypeTest.CodecSupportTest_av1, where TypeParam = and GetParam() = (461 ms)
,
Nov 27 2017
Ah, sill me, used defined() with a BUILDFLAG.
,
Nov 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65da292b4803ebc0c1279bf7ad817d0d18926926 commit 65da292b4803ebc0c1279bf7ad817d0d18926926 Author: Dale Curtis <dalecurtis@chromium.org> Date: Tue Nov 28 00:23:09 2017 Don't use defined() for a BUILDFLAG() in canPlayType browsertest. Also, just use the kPropProbably expectation which already sets this up correctly. BUG= 787514 TEST=none Change-Id: I44f16049ac94f574f272a2e4d9a1061c24181b59 Reviewed-on: https://chromium-review.googlesource.com/792097 Reviewed-by: Johann Koenig <johannkoenig@google.com> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#519473} [modify] https://crrev.com/65da292b4803ebc0c1279bf7ad817d0d18926926/content/browser/media/media_canplaytype_browsertest.cc
,
Nov 28 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dalecur...@chromium.org
, Nov 21 2017