WebRTC CL is breaking Windows MSVC 64 bits builds |
||
Issue descriptionThis WebRTC CL: https://webrtc-review.googlesource.com/c/src/+/21162 Seems to be causing the compile error below on Chromium Windows MSVC 64 bits builds: FAILED: obj/third_party/webrtc/media/rtc_audio_video/convert_legacy_video_factory.obj ninja -t msvc -e environment.x64 -- C:\b\c\goma_client/gomacc.exe "c:\b\c\win_toolchain\vs_files\a9e1098bba66d2acccc377d5ee81265910f29272\vc\tools\msvc\14.11.25503\bin\hostx64\x64/cl.exe" /nologo /showIncludes @obj/third_party/webrtc/media/rtc_audio_video/convert_legacy_video_factory.obj.rsp /c ../../third_party/webrtc/media/engine/convert_legacy_video_factory.cc /Foobj/third_party/webrtc/media/rtc_audio_video/convert_legacy_video_factory.obj /Fd"obj/third_party/webrtc/media/rtc_audio_video_cc.pdb" c:\b\c\b\win\src\third_party\webrtc\media\engine\convert_legacy_video_factory.cc(76) : error C2220: warning treated as error - no 'object' file generated c:\b\c\b\win\src\third_party\webrtc\media\engine\convert_legacy_video_factory.cc(76) : warning C4700: uninitialized local variable 'info' used It's breaking repeatedly because auto-roll is not detecting it before assimilating newer versions of the WebRTC repo. See blocked issue 787192 for details.
,
Nov 21 2017
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/09d584457a235af956c658b01e6a6725bb81ab6e commit 09d584457a235af956c658b01e6a6725bb81ab6e Author: Magnus Jedvert <magjed@webrtc.org> Date: Tue Nov 21 19:09:58 2017 Fix some uninitialized variables in convert_legacy_video_factory This is causing compilation failure on Chrome on Windows using MSVC 64bits. TBR=andersc@webrtc.org Bug: chromium:787192 Change-Id: If82290a9d7373385de4820b34f2c7dc9225c3d95 Reviewed-on: https://webrtc-review.googlesource.com/24981 Reviewed-by: Magnus Jedvert <magjed@webrtc.org> Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20821} [modify] https://crrev.com/09d584457a235af956c658b01e6a6725bb81ab6e/media/engine/convert_legacy_video_factory.cc
,
Nov 21 2017
This should be fixed now. |
||
►
Sign in to add a comment |
||
Comment 1 by magjed@chromium.org
, Nov 21 2017Status: Assigned (was: Available)