New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 787509 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: ----



Sign in to add a comment

test_push failed due to no package subprocess32

Project Member Reported by xixuan@chromium.org, Nov 21 2017

Issue description

ERROR:root:Task Python file tasks/atomic_afe.py failed to import.
Traceback (most recent call last):
  File "/usr/lib/python2.7/runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/usr/local/google/home/chromeos-test/chromiumos/chromeos-admin/venv/server_management_lib/interfaces/run_server_task.py", line 18, in <module>
    from server_management_lib.core import settings_manager
  File "/usr/local/google/home/chromeos-test/chromiumos/chromeos-admin/venv/server_management_lib/core/__init__.py", line 13, in <module>
    settings_manager.load_task_classes()
  File "/usr/local/google/home/chromeos-test/chromiumos/chromeos-admin/venv/server_management_lib/core/settings_manager.py", line 57, in load_task_classes
    task_classes = settings_loader.load_task_classes(task_registry_file)
  File "/usr/local/google/home/chromeos-test/chromiumos/chromeos-admin/venv/server_management_lib/core/settings_loader.py", line 154, in load_task_classes
    _load_task_classes_from_python_files(task_classes, python_files)
  File "/usr/local/google/home/chromeos-test/chromiumos/chromeos-admin/venv/server_management_lib/core/settings_loader.py", line 67, in _load_task_classes_from_python_files
    imp.load_source(module_name, full_file_path)
  File "/usr/local/google/home/chromeos-test/chromiumos/chromeos-admin/venv/server_management_lib/tasks/atomic_afe.py", line 13, in <module>
    from server_management_lib.tasks import atomic_common
  File "/usr/local/google/home/chromeos-test/chromiumos/chromeos-admin/venv/server_management_lib/tasks/atomic_common.py", line 30, in <module>
    from server_management_lib import stubby
  File "/usr/local/google/home/chromeos-test/chromiumos/chromeos-admin/venv/server_management_lib/stubby.py", line 13, in <module>
    from admin import subprocess32
ImportError: cannot import name subprocess32
If you need to contact the on-duty trooper, see: https://chromium.googlesou
rce.com/infra/infra/+/master/doc/users/contacting_troopers.md

 
Status: Started (was: Untriaged)
test_push is probably trying to run sml outside the venv, which is no longer supported.
This is totally my bad.
We removed our handrolled subprocess32 in favour of updated subprocess32 in the venv in 
https://chrome-internal-review.googlesource.com/c/chromeos/chromeos-admin/+/497312

I didn't realize this, and my local checkout had a pyc file sitting around from the old module so I didn't hit the error.

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/6dbccd3078fb4b53004c480dde5d52dba11fee37

commit 6dbccd3078fb4b53004c480dde5d52dba11fee37
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Tue Nov 21 19:27:14 2017

Status: Fixed (was: Started)

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 7 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment