New issue
Advanced search Search tips

Issue 787459 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome , Mac , Fuchsia
Pri: 2
Type: Bug

Blocked on:
issue 595685

Blocking:
issue 827924



Sign in to add a comment

Dispatch of non-persistent notification events should be acknowledged

Project Member Reported by peter@chromium.org, Nov 21 2017

Issue description

Right now the browser process sends an IPC to trigger the `click` and `close` events and never finds out when they were completed.

In order to run the completed closure of the NonPersistentNotificationHandler at the right time, we should make sure that the Mojo calls for triggering the event include an acknowledgement.
 

Comment 1 by awdf@chromium.org, Nov 21 2017

Blockedon: 595685
Blocking: -595685

Comment 2 by awdf@chromium.org, Jan 11 2018

Blocking: 442141

Comment 3 by awdf@chromium.org, Apr 18 2018

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, May 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60036df9cee4317b4c271b3b3e43c536d45ba1dd

commit 60036df9cee4317b4c271b3b3e43c536d45ba1dd
Author: Anita Woodruff <awdf@chromium.org>
Date: Wed May 02 12:41:14 2018

[Notifications] Postpone callback on non-persistent notification close

The callback should only be called after the notification close event
has completed. This change postpones execution of the callback until
the proper time.

I had to add some workarounds because for some reason it seems the
callback does not now get called from tests.

R=peter@chromium.org

Bug:  787459 
Change-Id: I4450d54894f79f3e83581686965a328ef961e383
Reviewed-on: https://chromium-review.googlesource.com/1018461
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Anita Woodruff <awdf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555361}
[modify] https://crrev.com/60036df9cee4317b4c271b3b3e43c536d45ba1dd/chrome/browser/notifications/non_persistent_notification_handler.cc
[modify] https://crrev.com/60036df9cee4317b4c271b3b3e43c536d45ba1dd/chrome/browser/notifications/stub_notification_display_service.cc
[modify] https://crrev.com/60036df9cee4317b4c271b3b3e43c536d45ba1dd/content/browser/notifications/blink_notification_service_impl.cc
[modify] https://crrev.com/60036df9cee4317b4c271b3b3e43c536d45ba1dd/content/browser/notifications/blink_notification_service_impl_unittest.cc
[modify] https://crrev.com/60036df9cee4317b4c271b3b3e43c536d45ba1dd/content/browser/notifications/notification_event_dispatcher_impl.cc
[modify] https://crrev.com/60036df9cee4317b4c271b3b3e43c536d45ba1dd/content/browser/notifications/notification_event_dispatcher_impl.h
[modify] https://crrev.com/60036df9cee4317b4c271b3b3e43c536d45ba1dd/content/browser/notifications/notification_event_dispatcher_impl_unittest.cc
[modify] https://crrev.com/60036df9cee4317b4c271b3b3e43c536d45ba1dd/content/public/browser/notification_event_dispatcher.h
[modify] https://crrev.com/60036df9cee4317b4c271b3b3e43c536d45ba1dd/third_party/blink/public/platform/modules/notifications/notification_service.mojom
[modify] https://crrev.com/60036df9cee4317b4c271b3b3e43c536d45ba1dd/third_party/blink/renderer/modules/notifications/notification.cc
[modify] https://crrev.com/60036df9cee4317b4c271b3b3e43c536d45ba1dd/third_party/blink/renderer/modules/notifications/notification.h

Blocking: 827924

Comment 6 by awdf@chromium.org, May 4 2018

Status: Fixed (was: Started)

Comment 7 by awdf@chromium.org, May 4 2018

Status: Assigned (was: Fixed)
Re-opening because actually this still needs implementing for the 'click' events. 

Comment 8 by awdf@chromium.org, May 16 2018

Owner: peter@chromium.org
Status: Started (was: Assigned)
Re-assigning to peter as he's implementing click acks as part of https://chromium-review.googlesource.com/c/chromium/src/+/1057631 for Issue 442141

Comment 9 by awdf@chromium.org, May 30 2018

Blocking: -442141

Comment 10 by awdf@chromium.org, May 30 2018

Status: Fixed (was: Started)
Closing as click acks were implemented as part of https://chromium-review.googlesource.com/1057631 ('Create a new tab when the user activates orphaned non-persistent notifications') 

Sign in to add a comment