Media Controls overflow menu should be closed on click |
||||||||
Issue descriptionChrome Version : 64.0.3272.0 OS Version: 10146.0.0 What steps will reproduce the problem? 1. Enable New Media Controls flag 2. Go to https://beaufortfrancois.github.io/sandbox/media/video.html 3. Click on the three vertical dots icon to open overflow menu 4. Click outside What is the expected result? The overflow menu should close. What happens instead of that? It stays open.
,
Nov 22 2017
@fbeaufort -- Thank You for the report.
Case (i)
Able to reproduce the issue on Android 7.1.0 (Samsung S7) on latest Canary# 64.0.3274.0.
This is a Non-Regression Issue starting M64# 64.0.3242.0 as the flag "New Media Controls" is available from the mentioned build.
Note: The overflow menu is not closing when clicked anywhere in the site (when any flag is not available) on Android (M52# 52.0.2743.98).
So marking the issue as Untriaged for further inputs.
Case (ii)
Able to reproduce the issue on Windows, Mac and Linux using Chrome Canary# 64.0.3275.0.
Launch Chrome and Navigate to the URL https://beaufortfrancois.github.io/sandbox/media/video.html
Click on three dots menu and click on the video. The overflow menu does not disappear. (Clicking on the empty space the menu disappears.
This is a Non-Regression Issue starting M64# 64.0.3242.0 as the flag "New Media Controls" is available from the mentioned build. In M63 builds, the flag "New Media Controls" is not available and there is no three dot menu in the video.
Thank You.
,
Nov 22 2017
,
Nov 22 2017
,
Dec 19 2017
,
Jan 5 2018
,
Jan 12 2018
,
Jan 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b3f54f7930bf20f8211fa8c696ca14d85af8b834 commit b3f54f7930bf20f8211fa8c696ca14d85af8b834 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Jan 17 00:46:55 2018 Let MediaControlsWindowEventListener listen on the overlay play button This CL adds MediaControlsWindowEventListener as an event listener on the MediaControlOverlayPlayButton. This allows the MCWEL to get click events from the MCOPB and properly close the overflow menu when the user clicks within the video. Bug: 787455 Change-Id: I53be671e59259c172157394ae1aa2572cdbd7bdd Reviewed-on: https://chromium-review.googlesource.com/865770 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#529528} [add] https://crrev.com/b3f54f7930bf20f8211fa8c696ca14d85af8b834/third_party/WebKit/LayoutTests/media/controls/modern/singletap-on-overlay-closes-overflow-menu.html [modify] https://crrev.com/b3f54f7930bf20f8211fa8c696ca14d85af8b834/third_party/WebKit/Source/modules/media_controls/MediaControlsWindowEventListener.cpp
,
Jan 17 2018
Verified in Chromium 65.0.3324.0 (Developer Build) (64-bit). Thank you!
,
Jan 17 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by pnangunoori@chromium.org
, Nov 22 2017