New issue
Advanced search Search tips

Issue 787447 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug


Participants' hotlists:
Modern-Media-Controls


Sign in to add a comment

Right-click should work on all the video element

Project Member Reported by fbeaufort@chromium.org, Nov 21 2017

Issue description

Chrome Version       : 64.0.3272.0
OS Version: 10146.0.0

What steps will reproduce the problem?
1. Enable New Media Controls flag
2. Go to https://beaufortfrancois.github.io/sandbox/media/video.html
3. Right-click video (not media controls such as timeline or play button)

What is the expected result?
It should open browser video context menu

What happens instead of that?
It does nothing
 
Can you be more specific as to the name of the flag? I'm not finding the flag with that name.
The "New Media Controls" flag is available at chrome://flags/#enable-modern-media-controls
Labels: -Pri-3 M-65 Pri-2
Owner: beccahughes@chromium.org
Status: Assigned (was: Unconfirmed)
I can confirm that I can't right on most of the video element. It's only working on buttons.
Cc: steimel@chromium.org
Owner: steimel@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e04fc5d22d9a82a7c1b91142d65ceb96cd6b1eca

commit e04fc5d22d9a82a7c1b91142d65ceb96cd6b1eca
Author: Tommy Steimel <steimel@chromium.org>
Date: Thu Dec 21 13:50:19 2017

Call superclass event handler in MediaControlOverlayPlayButtonElement

This CL adds a call to properly propagate events on the overlay play
button element. This fixes an issue where right-clicks on the outer
parts of the overlay were not opening the video context menu.

Bug:  787447 
Change-Id: Ic80966fc2e757bec68167bc03e959b9000d82d4b
Reviewed-on: https://chromium-review.googlesource.com/838081
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525684}
[modify] https://crrev.com/e04fc5d22d9a82a7c1b91142d65ceb96cd6b1eca/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.cpp

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified in Chromium 65.0.3302.0.
Thank you!
Labels: TE-Verified-M65 TE-Verified-65.0.3309.0
Tested this issue on Windows 7, Mac 10.12.6 & Ubuntu 14.04 using chrome latest Canary#65.0.3309.0 as per steps mentioned in C#0.

Able to view 'video context menu' upon right click on video while playing and before palying also.All the context menu options are working correctly without any issue.

Please find the attached screencast for reference.Hence adding TE Verified labels for the same.

Thanks..!

787447.mp4
2.7 MB View Download

Sign in to add a comment