Icons on Media Controls Overflow Menu are not padded to the left |
|||||
Issue descriptionGoogle Chrome 64.0.3272.0 (Official Build) canary (64-bit) Revision 0 Platform 10146.0.0 (Official Build) canary-channel eve Firmware Version Google_Eve.9584.107.0 What steps will reproduce the problem? 1. Enable New Media Controls flag 2. Enable Icons on Media Controls Overflow Menu flag 3. Go to https://beaufortfrancois.github.io/sandbox/media/video.html What is the expected result? Icons on Media Controls Overflow Menu should look great What happens instead? Icons on Media Controls Overflow Menu have no padding/margin to the left
,
Nov 22 2017
,
Nov 22 2017
Tested the issue in Android and could reproduce the issue. Steps Followed: 1. Launched Chrome Browser 2. Enabled New Media Controls flag & Icons on Media Controls Overflow Menu flag 3. Observed the media controls are looks a bit weird Chrome versions tested: 64.0.3274.0 OS Android 7.0.99 Android Devices 7.0.99, Pixel Build/PPR1.171120 Please navigate to below link for log's and video-- go/chrome-androidlogs/787445 Note: 1. Issue is seen using #64.0.3275.0 on Mac 10.12.6, Win 10 and Linux Ubuntu 14.04 as well 2. This looks to be a Non-Regression issue as Media Controls flag & Icons on Media Controls Overflow Menu flag are recently available in chrome://flags since M63, M64 3. Removing Needs-Bisect as this is a Non-Regression issue. Thanks!!
,
Nov 22 2017
,
Nov 22 2017
Is this something that we should get fixed as part of the experiment with the icons?
,
Nov 22 2017
No this is only for the new media controls
,
Dec 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c62ed353cdf70322fd7c4bc0eb29a602d16cc23b commit c62ed353cdf70322fd7c4bc0eb29a602d16cc23b Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Dec 07 13:04:26 2017 Media Controls: Fix overflow icon padding Fix overflow icon padding on the new media controls if the overflow icons are enabled. BUG= 787445 Change-Id: I2f2ec5a56839ccada45feebcd10b18fcbb82a749 Reviewed-on: https://chromium-review.googlesource.com/813915 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#522409} [modify] https://crrev.com/c62ed353cdf70322fd7c4bc0eb29a602d16cc23b/third_party/WebKit/Source/modules/media_controls/resources/modernMediaControls.css
,
Dec 7 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ligim...@chromium.org
, Nov 21 2017