Media Controls timeline is wrong when media fragment is defined |
|||||||||||||
Issue descriptionChrome Version : 64.0.3272.0 OS Version: 10146.0.0 What steps will reproduce the problem? 1. Enable New Media Controls flag 2. Go to https://beaufortfrancois.github.io/sandbox/media/video.html What is the expected result? The media controls timeline should look good What happens instead of that? The media controls timeline width is too large.
,
Nov 22 2017
,
Nov 22 2017
,
Dec 19 2017
,
Dec 19 2017
,
Jan 5 2018
,
Jan 18 2018
fbeaufort@, is this still an issue? I'm unable to reproduce with current code
,
Jan 19 2018
I can still reproduce on my Mac with Google Chrome 65.0.3325.0 (Official Build) canary (64-bit)
,
Jan 19 2018
Oh I misunderstood the problem. I can reproduce that issue as well, but couldn't repro the extra-long bar shown in the initial picture. Thanks!
,
Jan 22 2018
,
Jan 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7d5300e593dda8e8643143fa587dd1493109381 commit a7d5300e593dda8e8643143fa587dd1493109381 Author: Tommy Steimel <steimel@chromium.org> Date: Tue Jan 23 00:39:43 2018 Refactor timeline segment positioning for Modern Media Controls This CL modifies the timeline segment positioning calculation for modern media controls to use the width of the timeline track instead of the timeline itself. This fixes a bug where the segments were slightly off. Also, this CL switches the "before" and "after" segments to make more sense. The before segment was after the thumb and the after segment was before the thumb. This CL puts the before segment before the thumb and the after segment after the thumb. Bug: 787443 Change-Id: I59442596b2475ba007380adffee7aa4d11b7b699 Reviewed-on: https://chromium-review.googlesource.com/879546 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#531090} [modify] https://crrev.com/a7d5300e593dda8e8643143fa587dd1493109381/third_party/WebKit/Source/modules/media_controls/elements/MediaControlSliderElement.cpp [modify] https://crrev.com/a7d5300e593dda8e8643143fa587dd1493109381/third_party/WebKit/Source/modules/media_controls/elements/MediaControlSliderElement.h [modify] https://crrev.com/a7d5300e593dda8e8643143fa587dd1493109381/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.cpp [modify] https://crrev.com/a7d5300e593dda8e8643143fa587dd1493109381/third_party/WebKit/Source/modules/media_controls/resources/modernMediaControls.css
,
Jan 23 2018
,
Jan 23 2018
Tested the issue on 66.0.3329.0 using Windows 10,Mac 10.13.1 and Ubuntu 14.04 and is still reproducible. Seeing same behaviour as in screenshot of comment#8. Attaching screenshot for reference. @steimel: Please check the screenshot and let us know if the fix is working as Expected. Thanks!
,
Jan 23 2018
Hi, it looks like the fix is working based on your screenshot. The timeline segment is is the correctly spot touching the thumb
,
Feb 2 2018
Re-opening because it seems that the bug is that the "grey area" (not loaded) does not appear or am I misunderstanding this?
,
Feb 2 2018
hmm from what I understand that's a separate problem. If you look at the screenshot from comment 8, the issue was that the bar was in the wrong spot (it was supposed to be touching the thumb. It was off due to position calculation problems.
,
Feb 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93f209d5e8adbdce5a229385752eec2570cc4713 commit 93f209d5e8adbdce5a229385752eec2570cc4713 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Feb 07 17:13:10 2018 Prevent quirks mode from hiding the timeline on modern media controls Quirks mode adds a box-sizing attribute to the range inside of a video, which ends up setting the timeline height to zero. This CL modifies the media controls CSS to override the quirks mode CSS. Bug: 787443 Change-Id: Id6a065caafcf04b0a1c2572aa388231dbfb05f29 Reviewed-on: https://chromium-review.googlesource.com/906588 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#535033} [add] https://crrev.com/93f209d5e8adbdce5a229385752eec2570cc4713/third_party/WebKit/LayoutTests/media/controls/modern/quirks-mode-timeline-is-not-hidden.html [modify] https://crrev.com/93f209d5e8adbdce5a229385752eec2570cc4713/third_party/WebKit/Source/modules/media_controls/resources/modernMediaControls.css
,
Feb 7 2018
Okay, I've also fixed the issue described in comment 15. Closing again
,
Feb 9 2018
Verified in Chrome 66.0.3344.0 for Mac. Thank you Tommy! |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by msrchandra@chromium.org
, Nov 22 2017Labels: Needs-triage-Mobile Triaged-Mobile M-64
Status: Untriaged (was: Unconfirmed)