New issue
Advanced search Search tips

Issue 787418 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

content_shell dumps ICCProfile warning all the time

Project Member Reported by mstensho@chromium.org, Nov 21 2017

Issue description

I get this all the time in the console (when running content_shell, not sure about chrome):

[31700:31700:1121/134139.861437:WARNING:icc_profile.cc(224)] Cannot fetch ICCProfile for invalid space.

I can get rid of it by passing --force-color-profile=srgb
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bc3d5ec4badb7429c10f26a4b5977a76eb026ce

commit 3bc3d5ec4badb7429c10f26a4b5977a76eb026ce
Author: Christopher Cameron <ccameron@chromium.org>
Date: Thu Nov 23 03:48:11 2017

Separate out platform specific ICCProfile uses

Wrap the ScreenInfo::icc_profile in a OS_MACOSX guard, since it
is not used (nor will be used) on other platforms.

Split ColorSpace::GetICCProfile into three separate functions for
the three different contexts in which it is needed
- ICCProfile::FromCacheMac for the Mac-specific power issues
- ICCProfile::FromParametricColorSpace for generating profiles
- ICCProfile::GetSkColorSpaceFromId for building LUTS

Give all three instances separate caches, since they don't need
to interact with each other (and trying to unify them creates
unpredictable behavior).

Enable histogramming of empty profiles (since they were not included
in UMAs before).

Bug:  787418 ,  766736 
Change-Id: I6794284fd3ca44d1a4667a8ce0f104948bdd596a
Reviewed-on: https://chromium-review.googlesource.com/783659
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518842}
[modify] https://crrev.com/3bc3d5ec4badb7429c10f26a4b5977a76eb026ce/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/3bc3d5ec4badb7429c10f26a4b5977a76eb026ce/content/browser/web_contents/web_contents_view_aura.cc
[modify] https://crrev.com/3bc3d5ec4badb7429c10f26a4b5977a76eb026ce/content/browser/web_contents/web_contents_view_mac.mm
[modify] https://crrev.com/3bc3d5ec4badb7429c10f26a4b5977a76eb026ce/content/common/frame_messages.h
[modify] https://crrev.com/3bc3d5ec4badb7429c10f26a4b5977a76eb026ce/content/public/common/screen_info.h
[modify] https://crrev.com/3bc3d5ec4badb7429c10f26a4b5977a76eb026ce/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/3bc3d5ec4badb7429c10f26a4b5977a76eb026ce/ui/display/display.cc
[modify] https://crrev.com/3bc3d5ec4badb7429c10f26a4b5977a76eb026ce/ui/display/win/color_profile_reader.cc
[modify] https://crrev.com/3bc3d5ec4badb7429c10f26a4b5977a76eb026ce/ui/display/win/color_profile_reader.h
[modify] https://crrev.com/3bc3d5ec4badb7429c10f26a4b5977a76eb026ce/ui/gfx/color_space.cc
[modify] https://crrev.com/3bc3d5ec4badb7429c10f26a4b5977a76eb026ce/ui/gfx/color_space.h
[modify] https://crrev.com/3bc3d5ec4badb7429c10f26a4b5977a76eb026ce/ui/gfx/color_transform.cc
[modify] https://crrev.com/3bc3d5ec4badb7429c10f26a4b5977a76eb026ce/ui/gfx/icc_profile.cc
[modify] https://crrev.com/3bc3d5ec4badb7429c10f26a4b5977a76eb026ce/ui/gfx/icc_profile.h
[modify] https://crrev.com/3bc3d5ec4badb7429c10f26a4b5977a76eb026ce/ui/gfx/icc_profile_unittest.cc
[modify] https://crrev.com/3bc3d5ec4badb7429c10f26a4b5977a76eb026ce/ui/gfx/mac/io_surface.cc

Status: Fixed (was: Assigned)
Thanks a lot!

Sign in to add a comment