New issue
Advanced search Search tips

Issue 787398 link

Starred by 1 user
Status: WontFix
Owner:
verwa...@chromium.org
Closed: May 2018
Cc:
japhet@chromium.org
yangguo@chromium.org
kouhei@chromium.org
dtu@chromium.org
mlippautz@google.com
verwa...@chromium.org
ishell@chromium.org
hirosh...@chromium.org
mstarzinger@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1%-183.1% regression in system_health.memory_desktop at 514257:514455

Project Member Reported by mlippautz@google.com, Nov 21 2017 
See the link to graphs below.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Nov 21 2017 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=787398

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=c72291f9e12b9adda22f245cafaede80f31b4cf771b84224fe1c97baadc9045d


Bot(s) for this bug's original alert(s):

android-nexus5
android-nexus7v2
chromium-rel-mac-retina
chromium-rel-mac11
chromium-rel-mac11-pro
chromium-rel-mac12
chromium-rel-mac12-mini-8gb
chromium-rel-win10
chromium-rel-win7-dual
chromium-rel-win7-gpu-ati
chromium-rel-win7-gpu-intel
chromium-rel-win7-gpu-nvidia
chromium-rel-win7-x64-dual
chromium-rel-win8-dual
linux-release
win-high-dpi
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Nov 21 2017 

馃搷 Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/14ec35a3f80000
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Nov 21 2017 

馃搷 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/14ec35a3f80000
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Feb 1 2018

Cc: ishell@chromium.org mstarzinger@chromium.org yangguo@chromium.org jarin@chromium.org verwa...@chromium.org leszeks@chromium.org kozyatinskiy@chromium.org hpayer@chromium.org u...@chromium.org
Owner: yangguo@chromium.org
Status: Assigned (was: Untriaged)
馃搷 Found significant differences after each of 5 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/15b80f46840000

[heap] Remove the old write barrier.
By ulan@chromium.org 路 Mon Nov 06 17:33:47 2017
v8 @ ef6c175c59240ba6f4770729cd1555332a25fa62

[ic] Migrate API getters to data handlers
By verwaest@chromium.org 路 Mon Nov 06 17:43:26 2017
v8 @ 460652c9786c686094b71f9d64e3e6025252c11a

[inspector] do not call native accessor in Rumtime.getProperties
By kozyatinskiy@chromium.org 路 Mon Nov 06 17:45:46 2017
v8 @ ea04c6671ac002c22bd35ae8c3b57b1c3f7527b3

Drop custom accessor deoptimization support
By verwaest@chromium.org 路 Mon Nov 06 20:20:58 2017
v8 @ c82cd31325c174c92456e6d8a6f9f8a970d805d9

Reland: Snapshot: support rehashing property and element dictionaries.
By yangguo@chromium.org 路 Tue Nov 07 07:22:19 2017
v8 @ 656c640ca931cae22923a9f91305d26dec1fac93

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 7 by dtu@chromium.org, Feb 2 2018

Cc: -mlippautz@chromium.org -yangguo@chromium.org -leszeks@chromium.org -hpayer@chromium.org -jarin@chromium.org -kozyatinskiy@chromium.org -verwa...@chromium.org -ishell@chromium.org -mstarzinger@chromium.org -u...@chromium.org dtu@chromium.org mlippautz@google.com
Owner: verwa...@chromium.org
Looks like the biggest jump is at

Drop custom accessor deoptimization support
By verwaest@chromium.org 路 Mon Nov 06 20:20:58 2017
v8 @ c82cd31325c174c92456e6d8a6f9f8a970d805d9
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Feb 3 2018

Cc: ishell@chromium.org kouhei@chromium.org mstarzinger@chromium.org hirosh...@chromium.org japhet@chromium.org verwa...@chromium.org yangguo@chromium.org
馃搷 Found significant differences after each of 2 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/13c00bf6840000

Make script cache hits async by japhet@chromium.org
chromium @ 1aec1a92fb786cae0a24ff2b22d4858d4486252e

[ic] Migrate API getters to data handlers by verwaest@chromium.org
v8 @ 460652c9786c686094b71f9d64e3e6025252c11a

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 9 by verwa...@chromium.org, May 24 2018

Status: WontFix (was: Assigned)
Migrating API getters to data handlers was required to get rid of custom compiled ICs. That's good for memory overall, for performance and security. We should eat this for now and independently investigate data handler overhead and what we can do about it.
►

Sign in to add a comment