Issue metadata
Sign in to add a comment
|
[Missing Test]: Chrome_Mac: Crash Report - syncer::ModelTypeSyncBridge::OnSyncStarting |
||||||||||||||||||||||
Issue descriptionAutomated tests for the below commit have been missing.Please add test coverage ASAP to avoid regressions in future. CL: ---- https://chromium.googlesource.com/chromium/src/+/4f690e6d5faba7c626f49b95f368502f2fa1b416 Ref Bug: --------- https://bugs.chromium.org/p/chromium/issues/detail?id=783746 Thank you!
,
Dec 18 2017
,
Jan 4 2018
The bug(https://bugs.chromium.org/p/chromium/issues/detail?id=783746) is segment failure, which is controller tried to use TypedURLSyncBridge even when it is null. So the fix is trivia, just let controller check if TypedURLSyncBridge is initialed, and triger a DCHECK(NOTREACH()) if it is not. The bug is happened on race condition. Sync tried to schedule history task before history backend initialed TypedURLSyncBridge. So the The test is really hard to add right now since our test infrastructure do not allow this order. Since fix is trivia, and I have added a DCHECK there, normally we do not test DCHECK, so I think it is ok to do not add test for this case. But if someone think this is really important, free feel to re-open this bug, I will add a test for it, and remove DCHECK there. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by pnoland@chromium.org
, Dec 13 2017