Issue metadata
Sign in to add a comment
|
9%-10.2% improvement in webrtc_perf_tests at 20682:20732 |
||||||||||||||||||||
Issue descriptionCorresponds to revert and reland of https://webrtc-review.googlesource.com/c/src/+/23263. Is this an expected change?
,
Nov 21 2017
Oh, it's echo detector, not echo canceler. Sorry for the noise Per :).
,
Nov 21 2017
This change should not have any effect on this test, the CL probably causes a change in the binary size or something. I think we should remove this test, since it is pretty unreliable and flaky, and it triggers on a lot of unrelated CLs (like this one), and I think we've never found an actual bug by using it.
,
Nov 21 2017
The only way how this CL may affect the metrics is what echo detector is relying on the capture ntp timestamps of audio frames and slight change in them (they should be more reliable now) causes different results. But I think it's very unlikely, as the first spike in the graphs is corresponding to chromium roll and my Cl in question causes second drop only on the second graph. On the first graph the second drop corresponds to another my CL, completely unrelated to audio.
,
Nov 23 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Nov 21 2017