Issue metadata
Sign in to add a comment
|
Regression: Unwanted allowed label is seen for cookie when 'Clear on exit' action is performed.
Reported by
aiman.an...@etouch.net,
Nov 21 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version: 63.0.3239.59 (Official Build) e1443a5742ff0c6b1112c387e627d7018cdb9ecb-refs/branch-heads/3239@{#550} (cohort: Stable) (32/64-bit) OS: Win(7,8,10), Mac(10.12.6, 10.13.2) Linux(14.04 LTS). Test URL: https://www.google.com/gmail/about/# Steps to reproduce: 1. Launch chrome, go to the above URL, click on Security chip and go to Cookies. 2. On Cookies window, block any one cookie and navigate to block section. 3. In block section, select the cookie and click on 'Clear on exit' button. 4. Observe. Actual Result: Unwanted allowed label is seen for cookie when 'Clear on exit' action is performed. Expected Result: Allowed label should not be seen when 'Clear on exit' action is performed. This is regression issue broken in ‘M-63’ and and will soon update the bisect info. Using the per-revision bisect providing the bisect results, Good build: 63.0.3221.0 (Revision:503309) Bad build: 63.0.3222.0 (Revision:503582) You are probably looking for a change made after 503417 (known good), but no later than 503418 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/52f222600e564b90704e01198a616728e2f3b6f0..86a324e6362fa1606fb3131848e913f6b2991135 Suspect: https://chromium.googlesource.com/chromium/src/+/86a324e6362fa1606fb3131848e913f6b2991135 @ellyjones:Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thank You!
,
Nov 21 2017
M63 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
,
Nov 21 2017
Merge requested for 63 and 64.
,
Nov 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18ac7f17e5517f3d6ce9bebab472e87cb0292c6c commit 18ac7f17e5517f3d6ce9bebab472e87cb0292c6c Author: Elly Fong-Jones <ellyjones@google.com> Date: Tue Nov 21 20:03:02 2017 views: remove auxiliary text from collected cookies Right now, this text is redundant with the infobar, although it will need to be re-added when this dialog is redesigned without the infobar. Worse, it is inaccurate in the "clear on exit" case of the Blocked panel. Bug: 610428, 787375 Change-Id: I653ff6790f1b141a71007df38c09f8e917fcfa6b Reviewed-on: https://chromium-review.googlesource.com/782661 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#518347} [modify] https://crrev.com/18ac7f17e5517f3d6ce9bebab472e87cb0292c6c/chrome/browser/ui/views/collected_cookies_views.cc
,
Nov 21 2017
This bug requires manual review: We don't branch M64 until 2017-11-30. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 21 2017
This bug requires manual review: We are only 13 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 21 2017
,
Nov 21 2017
Thank you ellyjones@ for quick fix. Please update the bug once CL lsited at #4 is baked/verified in canary. If change looks good in canary and safe to merge, I will approve merge for M63.
,
Nov 22 2017
Tested this issue on Windows 7, Mac 10.12.6 & Ubuntu 14.04 using chrome latest Canary-64.0.3275.0 as per steps mentioned in C#0. 'Allowed' label is not seen when 'Clear on exit' action is performed on the below URL. https://www.google.com/gmail/about/# As it is working as intended, adding TE Verified labels. Please find the attached screencast for reference. Thanks..!
,
Nov 22 2017
The NextAction date has arrived: 2017-11-22
,
Nov 22 2017
Merge approved into M63. Please make sure to verify the fix on branch 3239 after merging it.
,
Nov 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c96d7df6e5c893099b4ab243e7d4f4ed8ec3d682 commit c96d7df6e5c893099b4ab243e7d4f4ed8ec3d682 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Mon Nov 27 15:48:57 2017 views: remove auxiliary text from collected cookies Right now, this text is redundant with the infobar, although it will need to be re-added when this dialog is redesigned without the infobar. Worse, it is inaccurate in the "clear on exit" case of the Blocked panel. TBR=ellyjones@google.com (cherry picked from commit 18ac7f17e5517f3d6ce9bebab472e87cb0292c6c) Bug: 610428, 787375 Change-Id: I20065f6823e60c6903a65d8ab022e77674cbdd58 Reviewed-on: https://chromium-review.googlesource.com/782661 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#518347} Reviewed-on: https://chromium-review.googlesource.com/790610 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#571} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/c96d7df6e5c893099b4ab243e7d4f4ed8ec3d682/chrome/browser/ui/views/collected_cookies_views.cc
,
Nov 28 2017
Rechecked this issue on M63 Build 63.0.3239.68 and merge is working fine. "Allowed" label is not seen when 'Clear on exit' action is performed on the below URL. https://www.google.com/gmail/about/# Adding TE-Verified labels for M63
,
Nov 28 2017
Just to update, issue was verified on Windows 10, Ubuntu 14.04 and MAC 10.12.6 Thanks.!
,
Nov 28 2017
Thanks! This bug is therefore Fixed. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rbasuvula@chromium.org
, Nov 21 2017