New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 787374 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 772803



Sign in to add a comment

desktop-pwas: If the app immediately redirects, open a new tab and close the app window

Project Member Reported by ortuno@chromium.org, Nov 21 2017

Issue description

What steps will reproduce the problem?
(1) Go to docs.google.com and install it
(2) Sign out of Google
(3) Try to open the Docs app

What is the expected result?
A new tab should open on accounts.google.com

What happens instead?
The app window opens up and navigates to accounts.google.com
 

Comment 1 by ortuno@chromium.org, Nov 21 2017

Status: Assigned (was: Available)

Comment 2 by ortuno@chromium.org, Nov 24 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6c580007359d625865dc4862d1393a84937313a

commit a6c580007359d625865dc4862d1393a84937313a
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Thu Nov 30 02:41:54 2017

desktop-pwas: Open in Chrome when an app immediately redirects to an out-of-scope URL

Apps should never navigate out-of-scope in the same window, so when
an app launches and immediately redirects to an out-of-scope URL,
continue the navigation in a regular Chrome window.

Bug:  787374 
Change-Id: I9ecd74ac06b398c19bb9d98317d37804b7576c15
Reviewed-on: https://chromium-review.googlesource.com/788727
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520395}
[modify] https://crrev.com/a6c580007359d625865dc4862d1393a84937313a/chrome/browser/extensions/bookmark_app_navigation_throttle.cc
[modify] https://crrev.com/a6c580007359d625865dc4862d1393a84937313a/chrome/browser/extensions/bookmark_app_navigation_throttle.h
[modify] https://crrev.com/a6c580007359d625865dc4862d1393a84937313a/chrome/browser/extensions/bookmark_app_navigation_throttle_browsertest.cc

Comment 4 by ortuno@chromium.org, Nov 30 2017

Status: Fixed (was: Started)

Sign in to add a comment