New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 787371 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Task
Team-Accessibility

Blocking:
issue 784583



Sign in to add a comment

Implement AtkDocument in AXPlatformNode

Project Member Reported by jose.dap...@lge.com, Nov 21 2017

Issue description

As part of the work for moving BrowserAccessibilityAuraLinux functionality to AxPlatformNode, add support for AtkDocument to AXPlatformNodeAuraLinux.

Though the goal is adding support for what is right now supported in BrowserAccessibilityAuraLinux (get_document_attribute_value and get_attributes).

To pair with WebKit atk support, we should implement get_locale, but it was deprecated and it is expected to be implemented in AtkObject interface level.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0740dcda437589da0b2483e0599e9ca9d2593bd1

commit 0740dcda437589da0b2483e0599e9ca9d2593bd1
Author: Jose Dapena Paz <jose.dapena@lge.com>
Date: Tue Nov 21 22:07:16 2017

ATK: fix AXPlatformNodeAuraLinux ATK interfaces detection.

For choosing the ATK interfaces to support, AXPlatformNodeAuraLinux
was retrieving AtkRole, but it was comparing it with AXRole values,
so it was assigning wrong interfaces to roles.

Bug: 784583,  787371 
Change-Id: Iad114c07e3e6860449b81771cb5d2808903fe603
Reviewed-on: https://chromium-review.googlesource.com/781761
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Cr-Commit-Position: refs/heads/master@{#518412}
[modify] https://crrev.com/0740dcda437589da0b2483e0599e9ca9d2593bd1/ui/accessibility/platform/ax_platform_node_auralinux.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff224a0d48fdf9732112d87234eb4b1a34d8ab16

commit ff224a0d48fdf9732112d87234eb4b1a34d8ab16
Author: Jose Dapena Paz <jose.dapena@lge.com>
Date: Thu Nov 23 18:29:38 2017

ATK: implement AtkDocument in AXPlatformNodeAuralinux.

Add support for AtkDocument interface, replicating the
implementation available in BrowserAccessibilityAuraLinux.

Bug:  787371 
Change-Id: I472ebaa61f8ff77bf38afbbe03ac4fc0e78030ac
Reviewed-on: https://chromium-review.googlesource.com/781762
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518985}
[modify] https://crrev.com/ff224a0d48fdf9732112d87234eb4b1a34d8ab16/ui/accessibility/platform/ax_platform_node_auralinux.cc
[modify] https://crrev.com/ff224a0d48fdf9732112d87234eb4b1a34d8ab16/ui/accessibility/platform/ax_platform_node_auralinux.h

Comment 3 by jose.dap...@lge.com, Nov 23 2017

Status: Verified (was: Untriaged)

Sign in to add a comment