New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 787331 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Overlay of bookmark doesn't appear properly after changing browser language to french.

Reported by vku...@etouch.net, Nov 21 2017

Issue description

Chrome Version:64.0.3274.0 (Official Build)Revision 38c9257b930f883c3ab936b1274590c94cc08012-refs/heads/master@{#518061} (32-bit)
OS:Win(7,8,10),

What steps will reproduce the problem?
(1)Launch chrome navigate to chrome://settings/ > languages section and select 'French(france)' language from 'All languages' list.
(2))Click on iron icon of French language and select 'display google chrome..' option, relaunch the browser.
(3)Click on bookmark (star)icon and observe.

Actual: Overlay of bookmark doesn't appear properly after changing browser language to french.

Expected:Overlay of bookmark should be properly seen after changing browser language to french.

This is a regression issue broken in 'M64' and will soon update other info.
 
Actual_Bookmark.png
93.0 KB View Download
Expected_Bookmark.png
92.5 KB View Download

Comment 1 by vku...@etouch.net, Nov 21 2017

Labels: hasbisect-per-revision
Owner: tapted@chromium.org
Status: Assigned (was: Unconfirmed)
Note: 
Actual: Extra padding is also observed below done button.
Expected: Extra padding should not be seen below done button.

You are probably looking for a change made after 513360 (known good), but no later than 513361 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/a28eb737c4c9424d7656ada19b688af854777968..1eca7aba022c190ea02e34dbd4ae52a8f5f88bbc

Suspecting: https://chromium.googlesource.com/chromium/src/+/1eca7aba022c190ea02e34dbd4ae52a8f5f88bbc
Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Issue not seen on Mac & Linux OS.
Actual_padding.png
105 KB View Download

Comment 2 by vku...@etouch.net, Nov 21 2017

Below is the manual regression range
Good Build: 64.0.3256.0 
Bad Build:  64.0.3257.0 

Comment 3 by tapted@chromium.org, Nov 21 2017

Cc: bsep@chromium.org bettes@chromium.org
Labels: Proj-HarmonyDialogs
I think these are all expected changes. In the 'expected' screenshot, the buttons are already cramped with the French strings. When the width of the "OK" button matches widths, the dialog width exceeds the threshold for the minimum size and snaps to the next standard dialog width.

The the "sign in to Chrome" link is configured not to split across lines, but it doesn't fit on the first line, and so wraps on to the second.

Comment 4 by bsep@chromium.org, Nov 27 2017

Status: WontFix (was: Assigned)
Agreed, this looks expected to me too.

Sign in to add a comment