New issue
Advanced search Search tips

Issue 787325 link

Starred by 1 user
Status: Started
Owner:
peria@chromium.org
Cc:
lfg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocked on:
issue 839389

Participants' hotlists:
Hotlist-Bindings-IDLCompiler


Sign in to add a comment

Merge InstallOriginTrialFeatures() functions into V8Foo::InstallConditionalFeatures

Project Member Reported by peria@chromium.org, Nov 21 2017 
We have 3 types of conditionally enabled features;

- runtime enabled features
- [SecureContext] features
- origin trial features

Roughly speaking, out of these features, only origin trial features are handled independently and have different paths to be installed.

InstallOriginTrialFeatures()
InstallOriginTrialFeaturesOnGlobal()

It is confusing that we have so many paths to install all necessary features.

So let's merge these functions and generated code called in them into V8Foo::InstallConditionalFeatures().
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a92cfc96142454dddc5805c1bf236454f0c5cf66

commit a92cfc96142454dddc5805c1bf236454f0c5cf66
Author: Hitoshi Yoshida <peria@chromium.org>
Date: Mon Nov 27 02:54:56 2017

bindings: Remove InstallOriginTrialFeaturesOnGlobal

InstallOriginTrialFeatuersOnGlobal (IOTFOG for shot) calls
V8Foo(Partial)::InstallConditionalFeaturesOnGlobal internally,
where Foo is the global object which the context has.

This CL moves the contents of V8Foo::ICFOG to V8Foo::ICF.
It enables to call them through WrapperTypeInfo, and it means
we no longer need IOTFOG.


Bug: 787325,  786153 ,  634270 
Change-Id: I50dc653f0f19a77fd9aa3a7b71fb985b4f68f781
Reviewed-on: https://chromium-review.googlesource.com/778699
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519207}
[modify] https://crrev.com/a92cfc96142454dddc5805c1bf236454f0c5cf66/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp
[modify] https://crrev.com/a92cfc96142454dddc5805c1bf236454f0c5cf66/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp
[modify] https://crrev.com/a92cfc96142454dddc5805c1bf236454f0c5cf66/third_party/WebKit/Source/bindings/scripts/v8_interface.py
[modify] https://crrev.com/a92cfc96142454dddc5805c1bf236454f0c5cf66/third_party/WebKit/Source/bindings/templates/OriginTrialFeaturesForCore.cpp.tmpl
[modify] https://crrev.com/a92cfc96142454dddc5805c1bf236454f0c5cf66/third_party/WebKit/Source/bindings/templates/OriginTrialFeaturesForModules.cpp.tmpl
[modify] https://crrev.com/a92cfc96142454dddc5805c1bf236454f0c5cf66/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl
[modify] https://crrev.com/a92cfc96142454dddc5805c1bf236454f0c5cf66/third_party/WebKit/Source/bindings/templates/interface.h.tmpl
[modify] https://crrev.com/a92cfc96142454dddc5805c1bf236454f0c5cf66/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl
[modify] https://crrev.com/a92cfc96142454dddc5805c1bf236454f0c5cf66/third_party/WebKit/Source/bindings/templates/partial_interface.h.tmpl
[modify] https://crrev.com/a92cfc96142454dddc5805c1bf236454f0c5cf66/third_party/WebKit/Source/bindings/tests/results/core/OriginTrialFeaturesForCore.cpp
[modify] https://crrev.com/a92cfc96142454dddc5805c1bf236454f0c5cf66/third_party/WebKit/Source/bindings/tests/results/modules/OriginTrialFeaturesForModules.cpp
[modify] https://crrev.com/a92cfc96142454dddc5805c1bf236454f0c5cf66/third_party/WebKit/Source/platform/bindings/OriginTrialFeatures.cpp
[modify] https://crrev.com/a92cfc96142454dddc5805c1bf236454f0c5cf66/third_party/WebKit/Source/platform/bindings/OriginTrialFeatures.h

Comment 2 by peria@chromium.org, May 3 2018

Blockedon: 839389

Comment 3 by peria@chromium.org, May 25 2018

Labels: Hotlist-Bindings-IDLCompiler
►

Sign in to add a comment