New issue
Advanced search Search tips

Issue 787315 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

[LayoutNG] Sometimes parts of text is slightly offset to the left

Project Member Reported by kojii@chromium.org, Nov 21 2017

Issue description

When we enable LayoutNGPaintFragments, parts of text is slightly offset to the left.

e.g., for "Letter spacing test" and "spacing test" is slightly offset to the left.

As I analyzed these results, this is because Times has kerning pairs for a space character and "s" (and some other characters) but the current layout engine does not use it. We have HasSpaceInLigaturesOrKerning() but it looks like it doesn't work, I'm not sure if this is intended perf optimization or unintentional.

Sometimes "This WebKit" and only "ebKit" is shifted. In this case, the position of "WebKit" is shifted internally, but due to font rendering, "W" is not affected.

I'm filing this bug to rebaseline images for LayoutNGPaintFragments.
 

Comment 1 by e...@chromium.org, Dec 1 2017

It is a perf optimization in that we ignore kernings with space (even if the font has them) unless kerning is explicitly turned on with css.

With NG we can finally remove this and rebaseline the tests.
Status: Fixed (was: Assigned)

Sign in to add a comment