Refactor VisibleSelection::ComputeVisibleSelection |
|||
Issue description
We will have ComputeVisibleSelection(passed_selection) {
const SelectionTemplate<Strategy>& xxx_adjusted_selection =
AdjustSelectionXXX(passed_selection);
const SelectionTemplate<Strategy>& yyy_adjusted_selection =
AdjustSelectionYYY(xxx_selection);
const SelectionTemplate<Strategy>& zzz_adjusted_selection =
AdjustSelectionZZZ(yyy_selection);
return zzz_adjusted_selection.
}
,
Nov 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0472547008329862d25a91d02479a6d5b9f5c2b commit d0472547008329862d25a91d02479a6d5b9f5c2b Author: Yoichi Osato <yoichio@chromium.org> Date: Tue Nov 21 10:06:02 2017 Move AdjustSelectionRespectingGranularity() to SelectionAdjuster. This patch moves the function to SelectionAdjuster. The file local class GranularityAdjuster is introduced to encapsul helper functions. Bug: 787295 Change-Id: I412bff47b1959bc879da5fd17f2c88933b336af2 Reviewed-on: https://chromium-review.googlesource.com/780962 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#518201} [modify] https://crrev.com/d0472547008329862d25a91d02479a6d5b9f5c2b/third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp [modify] https://crrev.com/d0472547008329862d25a91d02479a6d5b9f5c2b/third_party/WebKit/Source/core/editing/SelectionAdjuster.h [modify] https://crrev.com/d0472547008329862d25a91d02479a6d5b9f5c2b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
,
Nov 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc63c9ed0b2bcef4f1a2d337be9215d52dcc395a commit dc63c9ed0b2bcef4f1a2d337be9215d52dcc395a Author: Yoichi Osato <yoichio@chromium.org> Date: Tue Nov 28 03:48:10 2017 Move AdjustSelectionToAvoidCrossingShadowBoundaries() to SelectionAdjuster. This patch moves the function to SelectionAdjuster. The file local class ShadowBoundaryAdjuster is introduced to encapsul helper functions. Bug: 787295 Change-Id: Ic1b1be49b9aa6b4a29ff829b321cb6f1d4b270fd Reviewed-on: https://chromium-review.googlesource.com/784757 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#519552} [modify] https://crrev.com/dc63c9ed0b2bcef4f1a2d337be9215d52dcc395a/third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp [modify] https://crrev.com/dc63c9ed0b2bcef4f1a2d337be9215d52dcc395a/third_party/WebKit/Source/core/editing/SelectionAdjuster.h [modify] https://crrev.com/dc63c9ed0b2bcef4f1a2d337be9215d52dcc395a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
,
Nov 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c370b6673c61904b469e76d8b58051e3a804d96 commit 7c370b6673c61904b469e76d8b58051e3a804d96 Author: Yoichi Osato <yoichio@chromium.org> Date: Thu Nov 30 05:06:23 2017 Move AdjustSelectionToAvoidCrossingEditingBoundaries() to SelectionAdjuster. This patch moves the function and related local functions to SelectionAdjuster. The file local class EditingBoundaryAdjuster is introduced to encapsul helper functions. Bug: 787295 Change-Id: Id6b1ece18426339895f3034b07a9f366d4228189 Reviewed-on: https://chromium-review.googlesource.com/795752 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#520447} [modify] https://crrev.com/7c370b6673c61904b469e76d8b58051e3a804d96/third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp [modify] https://crrev.com/7c370b6673c61904b469e76d8b58051e3a804d96/third_party/WebKit/Source/core/editing/SelectionAdjuster.h [modify] https://crrev.com/7c370b6673c61904b469e76d8b58051e3a804d96/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
,
Dec 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b92e6f02bd63fd9421d087885a0461cd0198e643 commit b92e6f02bd63fd9421d087885a0461cd0198e643 Author: Yoichi Osato <yoichio@chromium.org> Date: Mon Dec 04 11:03:11 2017 Refactor ShadowBoundaryAdjuster. This patch makes only-internal-used functions declared in header to local. This patch also moves internal functions from anonymous namespace to ShadowBoundaryAdjuster. Bug: 787295 Change-Id: I4420a2f7364cd41b8a6bf25aefbce79b7991c1f3 Reviewed-on: https://chromium-review.googlesource.com/803177 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#521309} [modify] https://crrev.com/b92e6f02bd63fd9421d087885a0461cd0198e643/third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp [modify] https://crrev.com/b92e6f02bd63fd9421d087885a0461cd0198e643/third_party/WebKit/Source/core/editing/SelectionAdjuster.h
,
Jan 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56c4d736ea46948d86cebad1fce078b323e8bad2 commit 56c4d736ea46948d86cebad1fce078b323e8bad2 Author: Yoichi Osato <yoichio@chromium.org> Date: Fri Jan 12 05:04:16 2018 Refactor ShadowBoundaryAdjuster #3. This patch makes code early return in the case of not Range because ShadowBoundaryAdjuster adjusts only range. This patch also renames the variable name because it don't need the assumption that selection is granularity adjusted. Bug: 787295 Change-Id: I55e9f0d401ad009e2297bb51817cb0a7839f9a4b Reviewed-on: https://chromium-review.googlesource.com/861545 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#528883} [modify] https://crrev.com/56c4d736ea46948d86cebad1fce078b323e8bad2/third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp
,
Jan 24 2018
,
May 14 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by yoichio@chromium.org
, Nov 21 2017