New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 787293 link

Starred by 4 users
Status: Fixed
Owner:
msarda@chromium.org
Closed: Nov 2017
Cc:
ew...@chromium.org
tapted@chromium.org
msarda@chromium.org
patricia...@chromium.org
█ shrike@chromium.org
bklmn@chromium.org
█ rpop@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

User menu macviews implementation review

Project Member Reported by bettes@chromium.org, Nov 21 2017 
Chrome Version: 64.0.3273.0
OS: Mac

1. The grey hover states went missing on my latest Canary version. 

Prior viewings had the hover appear after a slight delay and an easing curve. I was fond of the curve, but not the timing. I'd like to see that re-implemented if possible. 

See hover.mov for a prototype of the expected design. 

Hover-in: (ease in and out)
- duration: 0.3s
- cubic bezier(.42,0,.58,1)

Hover-out: (ease out)
- duration: 0.3s
- cubic bezier(0,0,.58,1)


2. Sign in button (local profile) 

Sign in button should be full width. See local.png
menu_hover.mov
1.9 MB Download
local.png
153 KB View Download

Comment 1 by ew...@chromium.org, Nov 21 2017

Cc: rpop@chromium.org tapted@chromium.org bklmn@chromium.org shrike@chromium.org msarda@chromium.org
Labels: M-64
Owner: jlebel@chromium.org
FYI this relates to  Issue 728141 , moving user menu to MacViews implementation.

Re #1: per Trent's comment in the email thread, it was a conscious decision to remove the hover animation (see  Issue 784684 ). Alan - can you please comment on whether we explicitly want to bring that back, after looking through the linked issue?

Re #2: makes sense to me. Re-assigning to Jerome.

Comment 2 by msarda@chromium.org, Nov 22 2017

Owner: msarda@chromium.org
Status: Started (was: Assigned)
I'll take these bugs as I'm starting to ramp up on the user menu for DICE anyway.

Comment 3 by ew...@chromium.org, Nov 22 2017 

I noticed one more issue as well. When I opened the user menu in a non-syncing profile, the first row automatically focused, even without me hovering over it. It shouldn't focus until I hover over it.

GIF attached.
auto-focus.gif
1.7 MB View Download

Comment 4 by meh...@chromium.org, Nov 22 2017

Cc: patricia...@chromium.org
The missing hover in comment 0 was a regression and should be fixed in latest Canary with  issue 786715 .

re#3: Looks also like a regression. I filed  Issue 787885 .

Comment 5 by msarda@chromium.org, Nov 27 2017 

Note: The sign-in button has never been full width (not on Win, Linux or MacOS). I'll change it to be full width on all platforms.

Comment 6 by ew...@chromium.org, Nov 27 2017

Cc: ew...@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/939b7a40acbf0350ec948c1fdd6e2451c906a5ed

commit 939b7a40acbf0350ec948c1fdd6e2451c906a5ed
Author: Mihai Sardarescu <msarda@chromium.org>
Date: Tue Nov 28 09:30:26 2017

[signin] Make sign-in button full width on the profile chooser bubble.

Screenshot:
https://drive.google.com/a/chromium.org/file/d/1V1Vwt-YMX02NSgkbza-q836r0ENb2d2t/view?usp=sharing

Bug:  787293 
Change-Id: I209c9a138f6319435ef3717a93cbf4c31827a621
Reviewed-on: https://chromium-review.googlesource.com/790352
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519624}
[modify] https://crrev.com/939b7a40acbf0350ec948c1fdd6e2451c906a5ed/chrome/browser/ui/views/profiles/profile_chooser_view.cc

Comment 8 by msarda@chromium.org, Nov 28 2017

Status: Fixed (was: Started)
The sign-in button is full width now - see screenshot:
https://drive.google.com/a/chromium.org/file/d/1V1Vwt-YMX02NSgkbza-q836r0ENb2d2t/view?usp=sharing

Comment 9 by jmukthavaram@chromium.org, Nov 29 2017

Labels: TE-Verified-M64 TE-Verified-64.0.3280.0
Tested this issue on Windows 7,Mac 10.12.6 & ubuntu 14.04 using chrome latest Canary-64.0.3280.0 as per C#0 & C#3.

Observations:
-----------
1. Gray color observed when we hover on any of user menu.
2. Sign in button displayed in full width same as expected image in local.png
3. First row in user menu is not getting highlighted without we hover on that row (C#3)

As it is working as intended ,adding TE Verified labels.

Please find the attached screencast for reference.
Thanks..!
787293.mp4
835 KB View Download
►

Sign in to add a comment