New issue
Advanced search Search tips

Issue 787283 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Need ability to order groups in project page

Project Member Reported by efoo@chromium.org, Nov 21 2017

Issue description

In project page, we need ability to order groups in UI (so we can put Chromium Main on top)

Filing bug for tracking. Marking as LUCI-KnownIssues-UI
 

Comment 1 by efoo@chromium.org, Nov 21 2017

Components: -Infra>Platform Infra>Platform>Milo>LUCI

Comment 2 by efoo@chromium.org, Nov 21 2017

Labels: REQBY-LUCI-M4c-AndroidComplete

Comment 3 by no...@chromium.org, Nov 21 2017

Labels: Type-Feature
Perhaps we should preserve the order in the config. Can be done by adding “Ordinal int” field to Console entity. 

Comment 4 by estaab@chromium.org, Nov 21 2017

Labels: -Restrict-View-Google
Issue 790834 has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/fbcd6e0de08a8f044ccb7dc0dec4c3f561766ed6

commit fbcd6e0de08a8f044ccb7dc0dec4c3f561766ed6
Author: Jao-ke Chin-Lee <jchinlee@chromium.org>
Date: Mon Dec 04 22:37:21 2017

[milo] Prepare to support ordered builder groups.

Builder group order matches order of specification in the
config. This CL does not surface the ordering in the UI.

Bug:  787283 
Change-Id: I07da77fa3a280a422e819509f7f873c46622a799
Reviewed-on: https://chromium-review.googlesource.com/807164
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/fbcd6e0de08a8f044ccb7dc0dec4c3f561766ed6/milo/common/config.go
[modify] https://crrev.com/fbcd6e0de08a8f044ccb7dc0dec4c3f561766ed6/milo/common/config_test.go

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/e137a647b374734bcd0a6904b23389de95126d12

commit e137a647b374734bcd0a6904b23389de95126d12
Author: Jao-ke Chin-Lee <jchinlee@chromium.org>
Date: Tue Dec 05 00:57:13 2017

[milo] Surface ordered builder groups.

Bug:  787283 
Change-Id: I136cb459540e475ba19d66c3dea7d40763b48e75
Reviewed-on: https://chromium-review.googlesource.com/807354
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>

[modify] https://crrev.com/e137a647b374734bcd0a6904b23389de95126d12/milo/common/config.go
[modify] https://crrev.com/e137a647b374734bcd0a6904b23389de95126d12/milo/common/config_test.go

Owner: jchin...@chromium.org
Status: Assigned (was: Untriaged)

Comment 9 by efoo@chromium.org, Dec 5 2017

Labels: -LUCI-M0-Backlog LUCI-M3-Beta LUCI-M3-S13
Status: Fixed (was: Assigned)

Comment 11 by efoo@chromium.org, Jan 31 2018

Labels: LUCI-Beta

Comment 12 by efoo@chromium.org, Jan 31 2018

Labels: -LUCI-M3-Beta

Comment 13 by efoo@chromium.org, Feb 15 2018

Labels: -reqby-luci-m4c-AndroidComplete reqby-luci-AndroidComplete

Sign in to add a comment