New issue
Advanced search Search tips

Issue 787230 link

Starred by 1 user
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 780164



Sign in to add a comment

[MD Extensions] Shortcuts page scrollbar partially hidden.

Project Member Reported by dpa...@chromium.org, Nov 21 2017 
The shortcuts page is incorrectly sized which causes the scrollbar to be partially outside of the viewport (bottom arrow not reachable by the user), see screenshot.

100% height is used incorrectly, since it gives the page same height as the entire viewport as opposed to 100% of the remaining height (after subtracting the toolbar's height).

Comment 1 by dpa...@chromium.org, Nov 21 2017

Blocking: 780164

Comment 2 by dpa...@chromium.org, Nov 21 2017

Labels: Hotlist-Polish

Comment 3 by dpa...@chromium.org, Nov 21 2017 

Actually this is happening both on the main page, as well as the shortcuts page.
scrollbar_hidden_shortcuts.png
51.9 KB View Download
scrollbar_hidden.png
37.8 KB View Download

Comment 4 by dpa...@chromium.org, Nov 21 2017

Owner: dpa...@chromium.org
Status: Started (was: Available)
CL at https://chromium-review.googlesource.com/c/chromium/src/+/783172.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/969f8f8310b6dec35a17c7dc5d3fb170219bc96f

commit 969f8f8310b6dec35a17c7dc5d3fb170219bc96f
Author: dpapad <dpapad@chromium.org>
Date: Wed Nov 22 01:33:37 2017

MD Extensions polish: Fix shortcut page height and main page top margin.

Bug:  787230 , 787181 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I69b7010655e2c39a715660a1687f8cd76d4f1634
Reviewed-on: https://chromium-review.googlesource.com/783172
Reviewed-by: Dan Beam (no longer on Chrome) <dbeam@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518489}
[modify] https://crrev.com/969f8f8310b6dec35a17c7dc5d3fb170219bc96f/chrome/browser/resources/md_extensions/item_list.html
[modify] https://crrev.com/969f8f8310b6dec35a17c7dc5d3fb170219bc96f/chrome/browser/resources/md_extensions/keyboard_shortcuts.html

Comment 6 by dpa...@chromium.org, Nov 22 2017

Status: Fixed (was: Started)
►

Sign in to add a comment