New issue
Advanced search Search tips

Issue 787229 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[MD Extensions] Add 64px margin at the bottom of each page.

Project Member Reported by dpa...@chromium.org, Nov 21 2017

Issue description

Similar to MD Settings, see screenshot.
 
end_of_page_margin.png
101 KB View Download

Comment 1 by dpa...@chromium.org, Nov 22 2017

FYI for the list view, this is addressed at https://chromium-review.googlesource.com/c/chromium/src/+/786146. Error and detail view need to be addressed separately.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f77a030e8487c9c5c0c2c12f3e976b125230e98

commit 5f77a030e8487c9c5c0c2c12f3e976b125230e98
Author: dpapad <dpapad@chromium.org>
Date: Thu Nov 23 00:30:13 2017

MD Extensions polish: Add padding around item list.

Also add bottom padding for the entire page.

Bug:  787229 , 787195 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I70ec65807a43627db213f0cc698e756ce28dbdc0
Reviewed-on: https://chromium-review.googlesource.com/786146
Reviewed-by: Dan Beam (no longer on Chrome) <dbeam@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518813}
[modify] https://crrev.com/5f77a030e8487c9c5c0c2c12f3e976b125230e98/chrome/browser/resources/md_extensions/item_list.html

Owner: dschuyler@chromium.org
Status: Started (was: Available)
Owner: dpa...@chromium.org
CL for shortcuts page in review, https://chromium-review.googlesource.com/c/chromium/src/+/806930.
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9626adc1f298e14f9b3c8edd5d44ec8306e85fe4

commit 9626adc1f298e14f9b3c8edd5d44ec8306e85fe4
Author: dpapad <dpapad@chromium.org>
Date: Tue Dec 05 02:54:44 2017

MD Extensions polish: Add 64px margin at the bottom of shortcuts page.

Bug:  787229 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I173e9c72b269c69a18f9c7909cfc60a0158f4707
Reviewed-on: https://chromium-review.googlesource.com/806930
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521597}
[modify] https://crrev.com/9626adc1f298e14f9b3c8edd5d44ec8306e85fe4/chrome/browser/resources/md_extensions/keyboard_shortcuts.html

Status: Fixed (was: Started)

Sign in to add a comment