[CRD iOS] Display handler should fall back to GLES2 if GLES3 context fails to create |
||
Issue descriptionGiven that: * iPhone 4S is the last iPhone that doesn't support GLES3 * iPhone 4S support is dropped in iOS 10 * We are planning to drop support for iOS 9 soon It's unlikely that we ever need to fallback to GLES2, but I think it's better to still implement this just to be safe, given that doing so requires only 2-3 extra lines.
,
Nov 21 2017
We are using some new APIs from GLES3. For GLES2, we implement slower workarounds. For example: https://cs.chromium.org/chromium/src/remoting/client/display/gl_render_layer.cc?l=153&rcl=18ac7f17e5517f3d6ce9bebab472e87cb0292c6c
,
Nov 21 2017
In that case I'd argue that supporting GLES2 is not just a couple of extra lines. If you believe that we no longer support older devices, it might be appropriate to remove all support for GLES2, although keeping the fallback is probably better if you're not sure.
,
Nov 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7b8b2a2fbc4835aca7719a43c9b4b7114540852 commit e7b8b2a2fbc4835aca7719a43c9b4b7114540852 Author: Yuwei Huang <yuweih@chromium.org> Date: Tue Nov 21 20:26:14 2017 [CRD iOS] Fallback to GLES2 when GLES3 is not supported The percentage of seeing a GLES2-only device is low but it's still safer to handle that, given that doing so requires only a few more lines. Bug: 787224 Change-Id: I63650f3ce4c2afe93492b81e30d7075d7007ebdc Reviewed-on: https://chromium-review.googlesource.com/780801 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#518363} [modify] https://crrev.com/e7b8b2a2fbc4835aca7719a43c9b4b7114540852/remoting/ios/display/gl_display_handler.mm
,
Nov 21 2017
Okay... Then I'd change it to "making iOS fallback to GLES2 context only requires a few extra lines"... The actual GLES2 logic is inside the renderer and is shared with Android. For Android I don't think we want to drop GLES2 support anytime soon...
,
Nov 21 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by jamiewa...@chromium.org
, Nov 21 2017