New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 787222 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[MD Extensions] List Item view tooltip not to spec

Project Member Reported by dpa...@chromium.org, Nov 21 2017

Issue description

Thi tooltip displayed in the main view is different than the one in the details view (see screenshots).


- Should have 13px font size.
- Should be positioned above the icon, instead of below.
 
tooltip_comparison.png
135 KB View Download
Owner: scottchen@chromium.org
Status: Started (was: Available)
according to our other shared icon tooltip code, the font's supposed to be 12px. Is that fine?

https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/policy/cr_tooltip_icon.html?q=cr_tooltip_icon&sq=package:chromium&l=17
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9458ef4e2a08e52ee7d017ed155a84e855d07b1e

commit 9458ef4e2a08e52ee7d017ed155a84e855d07b1e
Author: Scott Chen <scottchen@chromium.org>
Date: Wed Nov 29 12:51:57 2017

MD Extensions: use paper-tooltip for extension's source-indicator.

This CL makes the tooltip style more consistent with other UI by using the same
element and styling for the source-indicator on extensions landing page.

Bug:  787222 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ied83dc00237694333f208096042ffd017f76d85d
Reviewed-on: https://chromium-review.googlesource.com/790370
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520086}
[modify] https://crrev.com/9458ef4e2a08e52ee7d017ed155a84e855d07b1e/chrome/browser/resources/md_extensions/item.html
[modify] https://crrev.com/9458ef4e2a08e52ee7d017ed155a84e855d07b1e/ui/webui/resources/cr_elements/policy/cr_tooltip_icon.html
[modify] https://crrev.com/9458ef4e2a08e52ee7d017ed155a84e855d07b1e/ui/webui/resources/cr_elements/shared_vars_css.html

Comment 3 by dpa...@chromium.org, Nov 30 2017

Status: Fixed (was: Started)
Assuming this is fixed now. Please re-open if not.

Sign in to add a comment