New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 787220 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[MD Extensions] Dev mode toolbar should animate

Project Member Reported by dpa...@chromium.org, Nov 21 2017

Issue description

When entering/exiting dev mode, currently the toolbar just snaps. It would be nice if it transitions as shown in the screenshot.
 
animate_toolbar.png
3.1 MB View Download

Comment 1 by dpa...@chromium.org, Nov 21 2017

Specs for the animation
 - Duration: 0.3s
 - cubic-bezier(.25,.1,.25,1) http://cubic-bezier.com/#.25,.1,.25,1

Comment 2 by dbeam@chromium.org, Nov 22 2017

Owner: dbeam@chromium.org
Status: Started (was: Available)

Comment 3 Deleted

Comment 4 by dbeam@chromium.org, Nov 23 2017

Cc: dbeam@chromium.org
Owner: ----
Status: Available (was: Started)
i'm not actually working on this, started with  bug 788018  (which is related but not quite the same)
Owner: dschuyler@chromium.org
Status: Started (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28f6dfebd737dd564b32f369a10d1c0738302d63

commit 28f6dfebd737dd564b32f369a10d1c0738302d63
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Wed Nov 29 20:18:10 2017

[MD extensions] animate dev controls

This cl transitions to/from showing the dev controls (developer mode)
over time, rather than snapping in/out of view.

Bug:  787220 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4b7e8176a284b77a68eced3b346031986340ff72
Reviewed-on: https://chromium-review.googlesource.com/792537
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520219}
[modify] https://crrev.com/28f6dfebd737dd564b32f369a10d1c0738302d63/chrome/browser/resources/md_extensions/toolbar.html
[modify] https://crrev.com/28f6dfebd737dd564b32f369a10d1c0738302d63/chrome/browser/resources/md_extensions/toolbar.js

Status: Fixed (was: Started)

Sign in to add a comment