New issue
Advanced search Search tips

Issue 787207 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 780164



Sign in to add a comment

[MD Extensions] Details page edges should have drop shadow.

Project Member Reported by dpa...@chromium.org, Nov 21 2017

Issue description

Similar to settings subpages (compare screenshots).
 
no_drop_shadow.png
14.7 KB View Download
drop_shadow.png
25.0 KB View Download

Comment 1 by dpa...@chromium.org, Nov 21 2017

Blocking: 780164

Comment 2 by dpa...@chromium.org, Nov 22 2017

Owner: dpa...@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d326faa6921266aeb9900a3928bf572441ed6b91

commit d326faa6921266aeb9900a3928bf572441ed6b91
Author: dpapad <dpapad@chromium.org>
Date: Wed Nov 22 20:07:35 2017

MD Extensions polish: Add drop shadow in details/error views.

Bug:  787207 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I02aa1a57a65265d97eebcc929335eb7bf19c891f
Reviewed-on: https://chromium-review.googlesource.com/784390
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Dan Beam (no longer on Chrome) <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518723}
[modify] https://crrev.com/d326faa6921266aeb9900a3928bf572441ed6b91/chrome/browser/resources/md_extensions/detail_view.html
[modify] https://crrev.com/d326faa6921266aeb9900a3928bf572441ed6b91/chrome/browser/resources/md_extensions/error_page.html

Comment 5 by dpa...@chromium.org, Nov 23 2017

Status: Fixed (was: Started)

Sign in to add a comment