New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 787199 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

graphics_WebGLPerformance: report sumOfFailed instead zero-to-nonzero

Project Member Reported by gurcheta...@chromium.org, Nov 21 2017

Issue description

While investigating  crbug.com/787087 , we noticed that the graphics_WebGLPerformance test outputs non-intuitive graphs.  For example, this graph reports a zero-to-nonzero regression:

https://chromeperf.appspot.com/group_report?bug_id=787087

In actuality, the test consists of 67 micro-benchmarks:

https://chromium.googlesource.com/chromiumos/third_party/autotest/+/master/client/site_tests/graphics_WebGLPerformance/graphics_WebGLPerformance.py

For  crbug.com/787087 , the number of failing tests jumped from 2 to 67 on Nyan.  The zero to non-zero metric apparently is based on the median of previous test results.

On Intel, the number of failing tests are zero -- so some added granularity would be useful (i.e, reporting sumOfFailed).
 

Comment 1 by pwang@chromium.org, Nov 21 2017

The 2 failed tests should be the waived tests (rgb-float). 

Purposed CL:780390 to report the actual number of failed tests to chromeperf.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/197c03aedee027bc2ba8d6f4c438da9daf903b09

commit 197c03aedee027bc2ba8d6f4c438da9daf903b09
Author: Po-Hsien Wang <pwang@chromium.org>
Date: Tue Nov 21 07:25:48 2017

graphics_WebGLPerformance: report number of failures

We moved the code to be calculated in python. So, lets report the actual
number of failures in this test so that the graph should be clearer to
understand.

BUG= chromium:787199 
TEST=test_that

Change-Id: I1fd745ac6f756e5415f4e3d1b31f42b41a191afd
Reviewed-on: https://chromium-review.googlesource.com/780390
Commit-Ready: Po-Hsien Wang <pwang@chromium.org>
Tested-by: Po-Hsien Wang <pwang@chromium.org>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>

[modify] https://crrev.com/197c03aedee027bc2ba8d6f4c438da9daf903b09/client/site_tests/graphics_WebGLPerformance/graphics_WebGLPerformance.py

Sign in to add a comment