New issue
Advanced search Search tips

Issue 787198 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 780164



Sign in to add a comment

[MD Extensions] Don't change icon color for disabled extensions.

Project Member Reported by dpa...@chromium.org, Nov 21 2017

Issue description

Currently disabled extensions have a grayscale icon color. Instead the color should stay the same.

Note: The icon seems to be coming directly from the C++, so changing it for both new and old UI is fine.
 

Comment 1 by dpa...@chromium.org, Nov 21 2017

Blocking: 780164

Comment 2 by dpa...@chromium.org, Nov 21 2017

Owner: dpa...@chromium.org
Status: Started (was: Available)
CL at https://chromium-review.googlesource.com/c/chromium/src/+/783553.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c68a3fbc0070ddab54555868001a1fbc2fb231a1

commit c68a3fbc0070ddab54555868001a1fbc2fb231a1
Author: dpapad <dpapad@chromium.org>
Date: Wed Nov 22 17:54:16 2017

MD Extensions polish: Don't change icon color for disabled extensions.

Preserve color logic for old UI.

Bug:  787198 
Change-Id: Iba8f80fe716f18d674e4410189a64aa0de3fa845
Reviewed-on: https://chromium-review.googlesource.com/783553
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518675}
[modify] https://crrev.com/c68a3fbc0070ddab54555868001a1fbc2fb231a1/chrome/browser/extensions/api/developer_private/extension_info_generator.cc

Comment 4 by dpa...@chromium.org, Nov 22 2017

Status: Fixed (was: Started)

Sign in to add a comment