New issue
Advanced search Search tips

Issue 787197 link

Starred by 0 users

Issue metadata

Status: Started
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocked on:
issue 821746



Sign in to add a comment

Implement tests to verify rendering behavior of headless chrome

Project Member Reported by dats@chromium.org, Nov 21 2017

Issue description

Implement rendering of various test pages and verify output against expectations to document and enforce behavior contract.
 

Comment 1 by dats@chromium.org, Nov 21 2017

Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92f7ee4e79476861b346af71efbd1b5360ac1f93

commit 92f7ee4e79476861b346af71efbd1b5360ac1f93
Author: Sergei Datsenko <dats@chromium.org>
Date: Wed Nov 22 08:41:10 2017

Add render test for a chain of different redirects.

Embed requested resources into tests. This will allow verifying more
complicated redirect chains, and also keeping inputs and outputs together
makes them more comprehensible.

Bug: chromium:787197
Change-Id: I705e0d859ad2cca8b686ea3b6e09b0af182eee30
Reviewed-on: https://chromium-review.googlesource.com/781379
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Sergei Datsenko <dats@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518572}
[delete] https://crrev.com/29723f2880dae7be2c58f12927df98bf2381ecd8/headless/test/data/render/console_errors.html
[delete] https://crrev.com/29723f2880dae7be2c58f12927df98bf2381ecd8/headless/test/data/render/delayed_completion.html
[delete] https://crrev.com/29723f2880dae7be2c58f12927df98bf2381ecd8/headless/test/data/render/javascript_override_title.html
[modify] https://crrev.com/92f7ee4e79476861b346af71efbd1b5360ac1f93/headless/test/headless_render_browsertest.cc
[modify] https://crrev.com/92f7ee4e79476861b346af71efbd1b5360ac1f93/headless/test/headless_render_test.cc
[modify] https://crrev.com/92f7ee4e79476861b346af71efbd1b5360ac1f93/headless/test/headless_render_test.h

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/141714f059243a2e86c5fcff6e596273a2cc60f9

commit 141714f059243a2e86c5fcff6e596273a2cc60f9
Author: Sergei Datsenko <dats@chromium.org>
Date: Tue Nov 28 23:25:05 2017

Numerous redirect rendertests.

Check handling of different types of redirects and their combinations.

Bug: chromium:787197
Change-Id: I6548c2802e000a2dd7913bbf1154797312b15361
Reviewed-on: https://chromium-review.googlesource.com/790051
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Sergei Datsenko <dats@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519894}
[modify] https://crrev.com/141714f059243a2e86c5fcff6e596273a2cc60f9/headless/test/headless_render_browsertest.cc
[modify] https://crrev.com/141714f059243a2e86c5fcff6e596273a2cc60f9/headless/test/headless_render_test.cc
[modify] https://crrev.com/141714f059243a2e86c5fcff6e596273a2cc60f9/headless/test/headless_render_test.h

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b6d718f3eb85d82aaae3ec72ce29356a45b8d79

commit 5b6d718f3eb85d82aaae3ec72ce29356a45b8d79
Author: Sergei Datsenko <dats@chromium.org>
Date: Fri Dec 01 10:00:14 2017

Add couple more redirect tests for headless renderer

Check preservation of fragments.
Check preservation of request method.

Bug: chromium:787197
Change-Id: I37b212d28420be74a140551f80ebdc0d6d7043c8
Reviewed-on: https://chromium-review.googlesource.com/802662
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Sergei Datsenko <dats@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520903}
[modify] https://crrev.com/5b6d718f3eb85d82aaae3ec72ce29356a45b8d79/headless/public/util/testing/test_in_memory_protocol_handler.cc
[modify] https://crrev.com/5b6d718f3eb85d82aaae3ec72ce29356a45b8d79/headless/test/headless_render_browsertest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e123abb6523ee083c307e462ef9bc6d80aacd1f

commit 8e123abb6523ee083c307e462ef9bc6d80aacd1f
Author: Sergei Datsenko <dats@chromium.org>
Date: Mon Dec 04 23:22:14 2017

Headless render tests.

Test setting and getting cookies.
Test window location access from fragments.

Bug: chromium:787197
Change-Id: I8dd9b16ebdfe5680a4977ec1e416b6447a70d44a
Reviewed-on: https://chromium-review.googlesource.com/805182
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Sergei Datsenko <dats@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521500}
[modify] https://crrev.com/8e123abb6523ee083c307e462ef9bc6d80aacd1f/headless/test/headless_render_browsertest.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7cd06d4e9d03a34893231e0f9466303746fc18e3

commit 7cd06d4e9d03a34893231e0f9466303746fc18e3
Author: Sergei Datsenko <dats@chromium.org>
Date: Thu Jan 04 00:02:16 2018

Headless render tests.

Test for cross-origin frames.
Test for content security policy.

Bug: chromium:787197
Change-Id: Ice5fc749edad052ceecd4bb8251a89198271fd89
Reviewed-on: https://chromium-review.googlesource.com/846612
Commit-Queue: Sergei Datsenko <dats@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526865}
[modify] https://crrev.com/7cd06d4e9d03a34893231e0f9466303746fc18e3/headless/test/headless_render_browsertest.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb6349300dcd0b04e57c1a7771044f153b0d158a

commit eb6349300dcd0b04e57c1a7771044f153b0d158a
Author: Sergei Datsenko <dats@chromium.org>
Date: Tue Jan 09 05:43:45 2018

Headless render test for frame loading events

Bug: chromium:787197
Change-Id: I0719452083f310d75d8bf589dfd927225996cdc7
Reviewed-on: https://chromium-review.googlesource.com/855216
Commit-Queue: Sergei Datsenko <dats@chromium.org>
Reviewed-by: David Vallet <dvallet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527910}
[modify] https://crrev.com/eb6349300dcd0b04e57c1a7771044f153b0d158a/headless/test/headless_render_browsertest.cc

Comment 10 by dats@chromium.org, Mar 7 2018

Owner: ----
Blockedon: 821746
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc850d8fd83abdc06a38569ad8aa42bf55dcee5e

commit dc850d8fd83abdc06a38569ad8aa42bf55dcee5e
Author: Eric Seckler <eseckler@chromium.org>
Date: Mon Mar 26 11:50:50 2018

headless: Support screenshots in HeadlessRenderTest.

Makes HeadlessRenderTest use CompositorController to render pages and
adds a way to capture and compare screenshots against golden files.

Also adds a custom font rendering test.

Because of the dependency on BeginFrameControl, these tests can now
only run on linux.

Bug: 787197
Change-Id: If0feaffb6d47cde624851c37db33e598b313668f
TBR: thakis@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/978217
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545762}
[modify] https://crrev.com/dc850d8fd83abdc06a38569ad8aa42bf55dcee5e/headless/BUILD.gn
[add] https://crrev.com/dc850d8fd83abdc06a38569ad8aa42bf55dcee5e/headless/test/DEPS
[add] https://crrev.com/dc850d8fd83abdc06a38569ad8aa42bf55dcee5e/headless/test/data/font.ttf
[add] https://crrev.com/dc850d8fd83abdc06a38569ad8aa42bf55dcee5e/headless/test/data/golden/custom_font.png
[modify] https://crrev.com/dc850d8fd83abdc06a38569ad8aa42bf55dcee5e/headless/test/headless_render_browsertest.cc
[modify] https://crrev.com/dc850d8fd83abdc06a38569ad8aa42bf55dcee5e/headless/test/headless_render_test.cc
[modify] https://crrev.com/dc850d8fd83abdc06a38569ad8aa42bf55dcee5e/headless/test/headless_render_test.h

Project Member

Comment 13 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff9617ac33368696f24887e40a68d2bdbb9179dc

commit ff9617ac33368696f24887e40a68d2bdbb9179dc
Author: Eric Seckler <eseckler@chromium.org>
Date: Wed Mar 28 15:44:23 2018

headless: Add CssUrlFilter render test.

Adds a test that verifies that a css filter: url(..) works correctly.

Bug: 787197
Change-Id: I9f4e6d31c80d399627d3d9c6dd2e4f764484733e
Reviewed-on: https://chromium-review.googlesource.com/983412
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546495}
[add] https://crrev.com/ff9617ac33368696f24887e40a68d2bdbb9179dc/headless/test/data/golden/css_url_filter.png
[modify] https://crrev.com/ff9617ac33368696f24887e40a68d2bdbb9179dc/headless/test/headless_render_browsertest.cc

Sign in to add a comment