New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 787192 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: ----

Blocked on:
issue 787513



Sign in to add a comment

compile failure on chromium.win/WinMSVC64 (dbg) due to bad webrtc roll

Project Member Reported by carl...@google.com, Nov 21 2017

Issue description

compile failure on chromium.win/WinMSVC64 (dbg)

Builders failed on: 
- WinMSVC64 (dbg): 
  https://build.chromium.org/p/chromium.win/builders/WinMSVC64%20%28dbg%29



 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7cdd8383c1c3f2f8c0b59d07068c543a2e24e79

commit b7cdd8383c1c3f2f8c0b59d07068c543a2e24e79
Author: Carlos Knippschild <carlosk@chromium.org>
Date: Tue Nov 21 00:26:50 2017

Revert "Roll src/third_party/webrtc/ 2707fb278..202be3957 (64 commits)"

This reverts commit 0366f1a82a0d2c4e0b82a3632e1dff5ee0b35690.

Reason for revert: broke WinMSVC64 (dbg) build bot. Culprit CL seems to be: https://webrtc-review.googlesource.com/c/src/+/21162

Original change's description:
> Roll src/third_party/webrtc/ 2707fb278..202be3957 (64 commits)
> 
> https://webrtc.googlesource.com/src.git/+log/2707fb2782e7..202be3957d95
> 
> $ git log 2707fb278..202be3957 --date=short --no-merges --format='%ad %ae %s'
> 
> Created with:
>   roll-dep src/third_party/webrtc
> BUG=None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None
> 
> 
> The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
> 
> If the roll is causing failures, please contact the current sheriff, who should
> be CC'd on the roll, and stop the roller if necessary.
> 
> 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
> TBR=webrtc-chromium-sheriffs-robots@google.com
> 
> Change-Id: I357c178ad4b6243456231ccf01f9f965d3962a21
> Reviewed-on: https://chromium-review.googlesource.com/779310
> Reviewed-by: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517979}

TBR=webrtc-autoroll@chromium.org,webrtc-chromium-sheriffs-robots@google.com

Change-Id: I706ac70581246daee3626ee31734490eb5c92d2f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  787192 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/780263
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518006}
[modify] https://crrev.com/b7cdd8383c1c3f2f8c0b59d07068c543a2e24e79/DEPS

Comment 3 by carl...@google.com, Nov 21 2017

Cc: andersc@chromium.org brandtr@chromium.org magjed@chromium.org
Components: Blink>WebRTC
CC-ing owner and reviewers from WebRTC related change.

Comment 4 by carl...@google.com, Nov 21 2017

First failing build was #213 with this compile error:

FAILED: obj/third_party/webrtc/media/rtc_audio_video/convert_legacy_video_factory.obj 
ninja -t msvc -e environment.x64 -- C:\b\c\goma_client/gomacc.exe "c:\b\c\win_toolchain\vs_files\a9e1098bba66d2acccc377d5ee81265910f29272\vc\tools\msvc\14.11.25503\bin\hostx64\x64/cl.exe" /nologo /showIncludes  @obj/third_party/webrtc/media/rtc_audio_video/convert_legacy_video_factory.obj.rsp /c ../../third_party/webrtc/media/engine/convert_legacy_video_factory.cc /Foobj/third_party/webrtc/media/rtc_audio_video/convert_legacy_video_factory.obj /Fd"obj/third_party/webrtc/media/rtc_audio_video_cc.pdb"
c:\b\c\b\win\src\third_party\webrtc\media\engine\convert_legacy_video_factory.cc(76) : error C2220: warning treated as error - no 'object' file generated
c:\b\c\b\win\src\third_party\webrtc\media\engine\convert_legacy_video_factory.cc(76) : warning C4700: uninitialized local variable 'info' used

Comment 5 by carl...@google.com, Nov 21 2017

Summary: compile failure on chromium.win/WinMSVC64 (dbg) due to bad webrtc roll (was: compile failure on chromium.win/WinMSVC64 (dbg))

Comment 6 by carl...@google.com, Nov 21 2017

Owner: carlosk@chromium.org
Status: Assigned (was: Available)
Owning it until tree is back to green.

Comment 7 by carl...@google.com, Nov 21 2017

Status: Fixed (was: Assigned)
Tree is back to green.
It's still happening.  Bug 787299 .

Comment 9 by carl...@google.com, Nov 21 2017

Status: Assigned (was: Fixed)
Indeed auto-rolls of webrtc are not detecting the compile error and keep on happening.

Comment 10 by carl...@google.com, Nov 21 2017

Labels: Pri-1

Comment 11 by carl...@google.com, Nov 21 2017

Blockedon: 787513

Comment 12 by h...@chromium.org, Nov 21 2017

Cc: dpranke@chromium.org r...@chromium.org
I think what happened is that the autoroll passed through the CQ because the warning is only happening on Debug builds, and the CQ only runs win-msvc-rel by default.

There is a win-msvc-dbg bot on the CQ too, but currently only as a 5% experiment since it needs more buildbot capacity.

+Dirk for the above.

I wouldn't expect the lack of coverage here to be a common problem, so I think WebRTC just got unlucky here. If you wanted to, you could force the autoroll CLs to include win-msvc-dbg in the CQ.
Project Member

Comment 13 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/09d584457a235af956c658b01e6a6725bb81ab6e

commit 09d584457a235af956c658b01e6a6725bb81ab6e
Author: Magnus Jedvert <magjed@webrtc.org>
Date: Tue Nov 21 19:09:58 2017

Fix some uninitialized variables in convert_legacy_video_factory

This is causing compilation failure on Chrome on Windows using MSVC
64bits.

TBR=andersc@webrtc.org

Bug:  chromium:787192 
Change-Id: If82290a9d7373385de4820b34f2c7dc9225c3d95
Reviewed-on: https://webrtc-review.googlesource.com/24981
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Commit-Queue: Magnus Jedvert <magjed@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20821}
[modify] https://crrev.com/09d584457a235af956c658b01e6a6725bb81ab6e/media/engine/convert_legacy_video_factory.cc

Yup, we'll get the debug configuration into the CQ asap.

Comment 15 by carl...@google.com, Nov 21 2017

 Issue 787299  has been merged into this issue.

Comment 16 by carl...@google.com, Nov 21 2017

It seems it'll take about 8h for the WebRTC fix to roll in so I'll revert the last roll now (what I should have done before anyway). 
Project Member

Comment 17 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38ed51a81113bf72765cb66d5a8a1653bc502165

commit 38ed51a81113bf72765cb66d5a8a1653bc502165
Author: Carlos Knippschild <carlosk@chromium.org>
Date: Tue Nov 21 23:22:42 2017

Revert "Roll src/third_party/webrtc/ 202be3957..ed1023db0 (19 commits)"

This reverts commit a2ec7611b737aba9a7d4d807ba44d5dc9cb55de4.

Reason for revert: This roll still does not include the fix for the build error on "chromium.win/WinMSVC64 (dbg)".
This had to be manually adjusted to the last working commit.

Original change's description:
> Roll src/third_party/webrtc/ 202be3957..ed1023db0 (19 commits)
>
> https://webrtc.googlesource.com/src.git/+log/202be3957d95..ed1023db0eb8
>
> $ git log 202be3957..ed1023db0 --date=short --no-merges --format='%ad %ae %s'
>
> Created with:
>   roll-dep src/third_party/webrtc
> BUG=None
>
>
> The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
>
> If the roll is causing failures, please contact the current sheriff, who should
> be CC'd on the roll, and stop the roller if necessary.
>
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
> TBR=webrtc-chromium-sheriffs-robots@google.com
>
> Change-Id: I660131e50f90463ee04ddd62292b7858525a8b03
> Reviewed-on: https://chromium-review.googlesource.com/781366
> Reviewed-by: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#518294}

TBR=webrtc-autoroll@chromium.org,webrtc-chromium-sheriffs-robots@google.com

Change-Id: I79ff7c5d777a62975b20ed5678f982b4e7f7d4ce
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  787192 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/783850
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518435}
[modify] https://crrev.com/38ed51a81113bf72765cb66d5a8a1653bc502165/DEPS

Status: Fixed (was: Assigned)
Successful build. Fixed.

Sign in to add a comment