Consider Previews whitelist and blacklist checks on committed URLs |
||||
Issue descriptionCurrently we make decision of candidate previews at the beginning of navigation (based on local blacklist, new NoScript whitelist, and effective connection type). We need to make the decision about server previews at this time in order to include request header to flywheel but for client previews, should we be checking the blacklist and whitelist at navigation commit time with the final URL (in case of redirects switching domains).
,
Dec 5 2017
,
Dec 5 2017
,
Jan 23 2018
Refreshed during triage.
,
Feb 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/138984db313500c1e2359d6556e967422ccef755 commit 138984db313500c1e2359d6556e967422ccef755 Author: Doug Arnett <dougarnett@chromium.org> Date: Wed Feb 14 23:41:45 2018 Rechecks NoScript Previews whitelist on committed URL At commit time, checks the NoScript optimization guide whitelist on the committed URL (since it may have changed from original URL domain due to redirects). Actually, the PreviewsDecider::ShouldAllowPreviewAtECT() api is used which also includes other checks as well (so alternatively we could add another api that is more specific/restricted instead). Bug: 787191 Change-Id: I6fac145eb661a1dcfd285030799ac29799cfacfe Reviewed-on: https://chromium-review.googlesource.com/909868 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#536888} [modify] https://crrev.com/138984db313500c1e2359d6556e967422ccef755/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc [modify] https://crrev.com/138984db313500c1e2359d6556e967422ccef755/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.h [modify] https://crrev.com/138984db313500c1e2359d6556e967422ccef755/chrome/browser/loader/chrome_resource_dispatcher_host_delegate_unittest.cc [modify] https://crrev.com/138984db313500c1e2359d6556e967422ccef755/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc [modify] https://crrev.com/138984db313500c1e2359d6556e967422ccef755/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc [modify] https://crrev.com/138984db313500c1e2359d6556e967422ccef755/components/previews/content/previews_content_util.cc [modify] https://crrev.com/138984db313500c1e2359d6556e967422ccef755/components/previews/content/previews_content_util.h [modify] https://crrev.com/138984db313500c1e2359d6556e967422ccef755/components/previews/content/previews_content_util_unittest.cc [modify] https://crrev.com/138984db313500c1e2359d6556e967422ccef755/components/previews/core/BUILD.gn [add] https://crrev.com/138984db313500c1e2359d6556e967422ccef755/components/previews/core/test_previews_decider.cc [add] https://crrev.com/138984db313500c1e2359d6556e967422ccef755/components/previews/core/test_previews_decider.h
,
Feb 27 2018
Opened 816964 for to refactor with new PreviewsDecider method. |
||||
►
Sign in to add a comment |
||||
Comment 1 by bengr@chromium.org
, Nov 29 2017Labels: -Pri-3 M-65 Pri-2
Status: Assigned (was: Untriaged)