Investigate removing EarlGrey helpers that Assert |
|||||
Issue descriptionWhen an EarlGrey helper method (ChromeEarlGrey) asserts, it is hard to find the call stack. When an assert is in a test method, that line shows up in the log. When an assert is in a helper, all you know is the test method that called the helper. If it is called multiple items in a test (e.g. waitForWebViewContainingText) you can't debug the test via logs.
,
Nov 21 2017
Yes, so if we could make ChromeEarlGrey a macro which prints the line number, and ChromeEarlGreyImpl a real class, that would work.
,
Nov 21 2017
As an FYI, I looked at EarlGrey's verbose logging, but that didn't provide much test context. It provided more information about what idling resources and animations were doing. I don't think it would help for this case. It is enabled via NSUserDefaults: [[NSUserDefaults standardUserDefaults] setBool:YES forKey:kGREYAllowVerboseLogging];
,
Nov 21
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 21
Yang, is this something that your team can tackle?
,
Jan 2
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by baxley@chromium.org
, Nov 21 2017