New issue
Advanced search Search tips

Issue 787182 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 788322
Owner:
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

2.2%-3612.6% regression in memory.desktop at 517159:517228

Project Member Reported by benhenry@google.com, Nov 21 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Nov 21 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=787182

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=fdbeb90b238052d9d9712e9bac4daf67f78214f688a82ab7c89fc2996584b1b8


Bot(s) for this bug's original alert(s):

chromium-rel-mac12
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Nov 21 2017

๐Ÿ“ Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/148385c3f80000
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Nov 21 2017

Cc: vmp...@chromium.org ericrk@chromium.org
Owner: ericrk@chromium.org
Status: Assigned (was: Untriaged)
๐Ÿ“ Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/148385c3f80000

Remove use of DeferredTextureImageData APIs and Support Decode to Scale
By ericrk@chromium.org ยท Thu Nov 16 22:15:14 2017
chromium @ 86c790e6a6dcdbec73f22ed343265963c901e749

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 4 by ericrk@chromium.org, Dec 19 2017

Mergedinto: 788322
Status: Duplicate (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea859b0e795297e0d0d69283aad1e4eace1ff7a8

commit ea859b0e795297e0d0d69283aad1e4eace1ff7a8
Author: Eric Karl <ericrk@chromium.org>
Date: Wed Jan 03 06:43:14 2018

Prevent Skia From Caching Uploaded Images w/ Color Conversion

When we upload an image and color convert it with Skia, Skia may decide
to re-use the original image's texture memory, keeping it in its cache.

This change causes the GPU Image Decode Cache to take ownership of and
delete this original image, preventing additional caching.

Bug:  787182 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: If1522276ba165b3c268a0631d9b7bd2c897489e7
Reviewed-on: https://chromium-review.googlesource.com/830978
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526639}
[modify] https://crrev.com/ea859b0e795297e0d0d69283aad1e4eace1ff7a8/cc/tiles/gpu_image_decode_cache.cc
[modify] https://crrev.com/ea859b0e795297e0d0d69283aad1e4eace1ff7a8/cc/tiles/gpu_image_decode_cache.h

Sign in to add a comment