Issue 787173 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	caseq@chromium.org
Closed:	Nov 2017
Cc:	mac-bugs-priority@chromium.org
Components:	Platform>DevTools>Platform
EstimatedDays:	----
NextAction:	----
OS:	Mac
Pri:	1
Type:	Bug

DevTools: renderer crashes when extraHTTPHeaders have https referer header

Project Member Reported by lushnikov@chromium.org, Nov 21 2017

Issue description

This has been filed downstream in PPTR:
- https://github.com/GoogleChrome/puppeteer/issues/1373

Long story short, the following DevTools protocol script crashes renderer:

  await Network.setExtraHTTPHeaders({referer: 'https://google.com'});
  await Page.navigate('http://example.com');

Project Member

Comment 1 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d9ed3b52ac5e58252357c0b75eef72f84ba2c1e

commit 2d9ed3b52ac5e58252357c0b75eef72f84ba2c1e
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Tue Nov 21 20:24:58 2017

DevTools: override referrer policy for the request if referer header is overriden

Bug:  787173 
Change-Id: Ia5d9aec2b96b5cfbfb25ff71d3a436a3575c16fd
Reviewed-on: https://chromium-review.googlesource.com/782141
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518362}
[add] https://crrev.com/2d9ed3b52ac5e58252357c0b75eef72f84ba2c1e/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/override-referer-with-downgrade-expected.txt
[add] https://crrev.com/2d9ed3b52ac5e58252357c0b75eef72f84ba2c1e/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/override-referer-with-downgrade.js
[modify] https://crrev.com/2d9ed3b52ac5e58252357c0b75eef72f84ba2c1e/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

Comment 2 by caseq@chromium.org, Nov 21 2017

Status: Fixed (was: Assigned)

►

Issue 787173 link

Issue metadata

DevTools: renderer crashes when extraHTTPHeaders have https referer header

Issue description

Comment 1 by bugdroid1@chromium.org, Nov 21 2017

Comment 1 Deleted

Comment 2 by caseq@chromium.org, Nov 21 2017

Comment 2 Deleted

Sign in to add a comment