New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 787159 link

Starred by 3 users
Status: Assigned
Owner:
█ rspangler@chromium.org
Last visit > 30 days ago
Cc:
philipchen@chromium.org
aaboagye@chromium.org
reinauer@chromium.org
█ rspangler@chromium.org
█ sha...@chromium.org
█ waihong@chromium.org
amstan@chromium.org
adurbin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

ec: Implement host command protocol V4

Project Member Reported by rspangler@chromium.org, Nov 20 2017 
Add support for new V4 packets.

Key new features:
- Sequence numbers, to detect / retry packets
- Use CRC-8 instead checksum
- Separate data CRC at end of packet from header CRC at end of header

See go/ec-hostcmd-v4 for details.

This requires changes in:
- The EC firmware
- Coreboot
- Depthcharge
- Kernel cros_ec driver
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/952189623d71852d4d4d438a4199592f8bcea034

commit 952189623d71852d4d4d438a4199592f8bcea034
Author: Randall Spangler <rspangler@chromium.org>
Date: Thu Nov 23 06:54:46 2017

ec_commands: Add structs for host command protocol V4

This only adds the structs for V4 packets.  Host command support for
them is coming in a subsequent CL.  V3 packets will continue to be
supported for a while, until all sides support V4.

BUG=chromium:787159
BRANCH=none
TEST=make -j runtests

Change-Id: I7e188a063d8ed60c85f3b8359959c424e3ccd1d9
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/780452
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>

[modify] https://crrev.com/952189623d71852d4d4d438a4199592f8bcea034/include/ec_commands.h

Comment 2 by rspangler@chromium.org, Jun 14 2018

Cc: reinauer@chromium.org aaboagye@chromium.org sha...@chromium.org rspangler@chromium.org amstan@chromium.org
 Issue 678675  has been merged into this issue.

Comment 3 by diand...@chromium.org, Aug 28

Cc: philipchen@chromium.org waihong@chromium.org
How's the v4 protocol going?  It would be peachy-keen if we could start getting the benefit of retries.

Comment 4 by rspangler@chromium.org, Aug 28 

As well as you'd expect for a P3 bug. ;)

Comment 5 by diand...@chromium.org, Aug 28 

@4: yeah, p3 bugs only get work done on them if people keep pinging them and asking for them.  So officially: "ping".  :-P
►

Sign in to add a comment