New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 787157 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

[Files] The mount names get changed as the same .rar file is opened from all the 3 folders (Drive, Downloads, USB)

Project Member Reported by mkarkada@chromium.org, Nov 20 2017

Issue description

Chrome OS: 10146.0.0, 64.0.3272.0 dev channel caroline device

What steps will reproduce the problem?
1. Create a .zip file and copy the same to Drive and external USB drive.
2. Now open this zip file from all the three folders - Drive, Downloads, USB.
3. Three different archive mounts with same name as the Zip file, is seen on the left navigation pane of Files app.
4. Now create a .rar file and copy the same to Drive and external USB drive.
5. Open this rar file from all the three folders - Drive, Downloads, USB.

What is the expected result?
Files app should display 3 different .rar mounts having same name as the file name. The behavior should be same as with .zip file.

What happens instead?
The mount names gets changed as the .rar archive file gets mounted.

Please refer the attachment and observe the left pane of Files app. 'sample.rar' file gets mounted as '.rar 1' and '.rar 2'. This doesn't happen with .zip file.
 
Screenshot 2017-11-20 at 2.45.04 PM.png
428 KB View Download
Cc: fukino@chromium.org mcirimele@chromium.org
Owner: yamaguchi@chromium.org
Status: Assigned (was: Untriaged)
We should treat .rar files the same as .zip files.

It makes more sense to me to keep just the name of the file if mounting from different sources rather than appending numbers to the name.
Status: started (was: Assigned)
The volume label of the mounted .rar files is de-duplicated when having multiple .rar files that has the same base name.

This happens because the internal, avfs-based unpacker mounts a file to a directory, and directory name is displayed to the UI as-is.
Provided volumes (ZIP/extensions) doesn't have this.
This is basically the same as the issue happened with removable storage devices.
https://chromium-review.googlesource.com/c/chromium/src/+/605108
We need to implement the same management logic to hold label and mount point separately like the one done for removable storage, or rewrite it to be shared among avfs volumes and disk volumes.
Status: Available (was: Started)
Labels: -M-64 M-65
Owner: fukino@chromium.org
Status: Assigned (was: Available)
fukino@, will you take a look at this, while I am on another issue?
Labels: -M-65 M-66
Owner: ----
Status: Available (was: Assigned)

Comment 7 by sashab@chromium.org, Feb 22 2018

Labels: CrOS-FilesApp-Zip

Comment 8 by sashab@chromium.org, Feb 28 2018

Labels: -CrOS-FilesApp-Zip CrOSFilesFeature-Zip
Labels: M-69
Labels: -M-66
Labels: -M-69

Sign in to add a comment