New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 787148 link

Starred by 1 user
Status: Fixed
Owner:
█ kapishnikov@chromium.org
Last visit > 30 days ago
Closed: Nov 2017
Cc:
█ xunji...@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , iOS
Pri: 1
Type: Bug-Regression



Sign in to add a comment

HTTP job is not resumed when retrying with proxy the second time

Project Member Reported by kapishnikov@chromium.org, Nov 20 2017 
When QUIC and HTTP jobs fail, we may retry the requests with proxy (see HttpStreamFactoryImpl::JobController::ReconsiderProxyAfterError). In that case we should resume both jobs. However, the HTTP job (main job) is not resumed. As the result, HttpStreamRequest::Delegate.OnStreamFailed() is never called since we wait for both jobs to complete before calling the delegate.

Comment 1 by xunji...@chromium.org, Nov 20 2017

Labels: -Type-Bug M-64 Type-Bug-Regression
Thanks for catching this! This is a regression introduced in 61.0.3121.0 (r477009). 

Andrei, since the fix is straightforward as discussed offline, can we aim to land this before M64's branch date (which is 11/30)? Thank you.

Comment 2 by mmenke@chromium.org, Nov 20 2017

Components: -Internals>Network>HTTP Internals>Network>Proxy
Labels: -Pri-2 Pri-1

Comment 3 by kapishnikov@chromium.org, Nov 21 2017

Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c2e70a2d9251e49b4d72e2344de54d031a5b228

commit 7c2e70a2d9251e49b4d72e2344de54d031a5b228
Author: kapishnikov <kapishnikov@chromium.org>
Date: Tue Nov 28 19:46:30 2017

Resume HTTP job when retrying request with different proxy

BUG= 787148 

Change-Id: I3b8de35f8179f6f45679d75ef210b9ec8500dab2
Reviewed-on: https://chromium-review.googlesource.com/794070
Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519800}
[modify] https://crrev.com/7c2e70a2d9251e49b4d72e2344de54d031a5b228/net/http/http_stream_factory_impl_job_controller.cc
[modify] https://crrev.com/7c2e70a2d9251e49b4d72e2344de54d031a5b228/net/http/http_stream_factory_impl_job_controller_unittest.cc

Comment 5 by kapishnikov@chromium.org, Nov 28 2017

Status: Fixed (was: Started)

Comment 6 by kapishnikov@chromium.org, Nov 28 2017

Labels: Merge-Request-64

Comment 7 by kapishnikov@chromium.org, Nov 28 2017

Labels: -Merge-Request-64
►

Sign in to add a comment