New issue
Advanced search Search tips

Issue 787142 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Launcher icon is misaligned at tablet view

Project Member Reported by abod...@chromium.org, Nov 20 2017

Issue description

Google Chrome	64.0.3272.0 (Official Build) dev (64-bit)
Platform	10146.0.0 (Official Build) dev-channel eve


Please specify Cr-* of the system to which this bug/feature applies (add
the label below).

Steps To Reproduce:
(1)login to user account 
(2)Change shelf position to "left" and open any window or tab.
(3)Move to tablet view and turn device to 90°
(4)Observe the launcher icon 

Expected Result:
launcher icon should be aligned 

Actual Result:
launcher icon and <- are not aligned 

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)

What is the impact to the user, and is there a workaround? If so, what is
it?

Please provide any additional information below. Attach a screen shot or
log if possible.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.


 
Screenshot 2017-11-20 at 14.35.24.png
5.7 MB View Download
Cc: abodenha@chromium.org
Summary: Launcher icon is misaligned at tablet view (was: Launcher icon is aligned at tablet view )

Comment 2 by vadimt@chromium.org, Nov 27 2017

Cc: newcomer@chromium.org sammiequon@chromium.org
Labels: Touch-Friendly-Launcher Touch-Friendly-Launcher-Triaged
Cc: -sammiequon@chromium.org
Owner: sammiequon@chromium.org
Status: Started (was: Untriaged)
The real bug is that the shelf move to the left in tablet mode - it should always be on the bottom.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9c65a49cf18b6cc4299b6e6c0e0b497359c9d1c

commit a9c65a49cf18b6cc4299b6e6c0e0b497359c9d1c
Author: Sammie Quon <sammiequon@google.com>
Date: Wed Nov 29 21:18:42 2017

shelf: Do not change autohide or alignment when in tablet mode.

Autohide should always be false, and alignment should always be bottom
aligned when in tablet mode, so display rotations and others should
not affect them.

Test: ash_unittests ShelfControllerPrefsTest.ShelfSettingsInTabletMode
Bug:  787142 
Change-Id: Ia2c5d43cdd0ddbe4982ca0b693a9411d8d9c267b
Reviewed-on: https://chromium-review.googlesource.com/795190
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520245}
[modify] https://crrev.com/a9c65a49cf18b6cc4299b6e6c0e0b497359c9d1c/ash/shelf/shelf_controller.cc
[modify] https://crrev.com/a9c65a49cf18b6cc4299b6e6c0e0b497359c9d1c/ash/shelf/shelf_controller_unittest.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on ChromeOS 10575.58.0, 67.0.3396.99 stable-channel eve

Sign in to add a comment